Skip to content

Commit 09751fc

Browse files
committed
CI: do not collect cores on cancelled workflows
Cancelling the workflow takes some time and may require clicking repeatedly as new jobs still start. The core collection is unconditional and usually not needed when cancellation is requested. Change the condition to proceed only when the previous steps finish. Signed-off-by: David Sterba <dsterba@suse.com>
1 parent 60518d4 commit 09751fc

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,7 +159,8 @@ jobs:
159159
collect-vmcore:
160160
runs-on: [self-hosted, linux, x64, vmhost]
161161
needs: [test, test-zoned]
162-
if: always()
162+
# Do not collect core when cancelled
163+
if: success() || failure()
163164
strategy:
164165
matrix:
165166
vm: [xfstests5, xfstests6, xfstests7, xfstests8, xfstests9, xfstests10]
@@ -176,7 +177,8 @@ jobs:
176177
collect-vmcore-arm:
177178
runs-on: [self-hosted, linux, ARM64, vmhost]
178179
needs: test-arm
179-
if: always()
180+
# Do not collect core when cancelled
181+
if: success() || failure()
180182
strategy:
181183
matrix:
182184
vm: [xfstests11, xfstests12]

0 commit comments

Comments
 (0)