feat(shelley): created genesis pools from shelley genesis #1054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jenita <jkawan@blinklabs.io>
Signed-off-by: Jenita <jkawan@blinklabs.io>
agaffney
requested changes
Jul 6, 2025
ledger/shelley/genesis.go
Outdated
| @@ -128,6 +204,32 @@ func (g *ShelleyGenesis) GenesisUtxos() ([]common.Utxo, error) { | |||
| return ret, nil | |||
| } | |||
|
|
|||
| // GetInitialPools returns all initial stake pools with their delegators | |||
| func (g *ShelleyGenesis) GetInitialPools() (map[string]GenesisPool, map[string][]string, error) { | |||
There was a problem hiding this comment.
Drop the Get prefix on the function. It's not idiomatic Go
ledger/shelley/genesis.go
Outdated
| } | ||
|
|
||
| // GetPoolById returns a specific pool by its ID along with its delegators | ||
| func (g *ShelleyGenesis) GetPoolById(poolId string) (*GenesisPool, []string, error) { |
There was a problem hiding this comment.
Drop the Get prefix on the function. It's not idiomatic Go
ledger/shelley/genesis.go
Outdated
| @@ -128,6 +204,32 @@ func (g *ShelleyGenesis) GenesisUtxos() ([]common.Utxo, error) { | |||
| return ret, nil | |||
| } | |||
|
|
|||
| // GetInitialPools returns all initial stake pools with their delegators | |||
| func (g *ShelleyGenesis) GetInitialPools() (map[string]GenesisPool, map[string][]string, error) { | |||
There was a problem hiding this comment.
We should return native ledger types here like we do above for GenesisUtxos(). At minimum, we should use common.Address where appropriate.
| Credential struct { | ||
| KeyHash string `json:"key hash"` | ||
| } `json:"credential"` | ||
| Network string `json:"network"` | ||
| } |
There was a problem hiding this comment.
There's a lot of overlap between these structures and common.PoolRegistrationCertificate, common.PoolRelay, and related types. We could probably merge them and avoid the need to convert/copy between them later.
ledger/shelley/genesis.go
Outdated
| } | ||
|
|
||
| // GetPoolById returns a specific pool by its ID along with its delegators | ||
| func (g *ShelleyGenesis) GetPoolById(poolId string) (*GenesisPool, []string, error) { |
There was a problem hiding this comment.
This should return []common.Address instead of []string
added 7 commits
July 18, 2025 17:40
Signed-off-by: Jenita <jkawan@blinklabs.io>
Signed-off-by: Jenita <jkawan@blinklabs.io>
Signed-off-by: Jenita <jkawan@blinklabs.io>
Signed-off-by: Jenita <jkawan@blinklabs.io>
Signed-off-by: Jenita <jkawan@blinklabs.io>
Signed-off-by: Jenita <jkawan@blinklabs.io>
Signed-off-by: Jenita <jkawan@blinklabs.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1042