From 52ffffa4bf663873c7e173cda65281fd4fe902d1 Mon Sep 17 00:00:00 2001 From: Steve Kim Date: Wed, 8 Jan 2025 10:47:32 -0800 Subject: [PATCH 1/3] add dispatch queue job for macos --- .github/workflows/ci.yml | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4aa03470b..6b0686006 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -205,6 +205,10 @@ jobs: macos: runs-on: macos-14 # latest + strategy: + fail-fast: false + matrix: + eventloop: ["kqueue", "dispatch_queue"] steps: - uses: aws-actions/configure-aws-credentials@v4 with: @@ -214,7 +218,7 @@ jobs: run: | python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder')" chmod a+x builder - ./builder build -p ${{ env.PACKAGE_NAME }} + ./builder build -p ${{ env.PACKAGE_NAME }} --cmake-extra=${{ matrix.eventloop }} macos-x64: runs-on: macos-14-large # latest From 7f60bc647a84fad91b41a2616541212651d54e92 Mon Sep 17 00:00:00 2001 From: Steve Kim Date: Wed, 8 Jan 2025 11:04:18 -0800 Subject: [PATCH 2/3] turn on dispatch queue for tests --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 6b0686006..d106cab3b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -218,7 +218,7 @@ jobs: run: | python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder')" chmod a+x builder - ./builder build -p ${{ env.PACKAGE_NAME }} --cmake-extra=${{ matrix.eventloop }} + ./builder build -p ${{ env.PACKAGE_NAME }} --cmake-extra=-DAWS_USE_APPLE_NETWORK_FRAMEWORK=${{ matrix.eventloop == 'dispatch_queue' && 'ON' || 'OFF' }} macos-x64: runs-on: macos-14-large # latest From 95e86fac335dfe7299f0e3a7776c52143ad8ceed Mon Sep 17 00:00:00 2001 From: Steve Kim Date: Thu, 9 Jan 2025 11:29:34 -0800 Subject: [PATCH 3/3] Kick CI