Skip to content

Commit 896ad70

Browse files
martinschaefMartin Schaef
andauthored
Codeinsight extra (#28)
* adding fields for details and link for CodeInsights * updating python oracle * escaping strings and extended error message * update version Co-authored-by: Martin Schaef <schaef@amazon.com>
1 parent 7519bae commit 896ad70

File tree

4 files changed

+11
-4
lines changed

4 files changed

+11
-4
lines changed

.github/workflows/self-test-and-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ jobs:
6464
if: steps.iam-role.outcome == 'success'
6565
shell: bash
6666
env:
67-
EXPECTED: 98
67+
EXPECTED: 102
6868
run: |
6969
[[ $(jq -r '.runs[0].results[].ruleId' code-guru/recommendations.sarif.json | wc -l) -eq $EXPECTED ]] || { echo "Expected $EXPECTED recommendations but got $(jq -r '.runs[0].results[].ruleId' code-guru/recommendations.sarif.json | wc -l)"; exit 1; }
7070

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ repositories {
2323

2424
defaultTasks 'clean', 'check', 'installDist'
2525

26-
version = '0.2.1'
26+
version = '0.2.3'
2727
jar.archiveName = "${jar.baseName}.${jar.extension}"
2828
distZip.archiveName = "${jar.baseName}.zip"
2929

src/main/java/com/amazonaws/gurureviewercli/model/bitbucket/CodeInsightsAnnotation.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,8 @@ public class CodeInsightsAnnotation {
4444
private String summary;
4545

4646
private String severity;
47+
48+
private String details;
49+
50+
private String link;
4751
}

src/main/java/com/amazonaws/gurureviewercli/util/CodeInsightExport.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,15 +50,16 @@ public static void report(final Collection<RecommendationSummary> recommendation
5050
.data(new ArrayList<>())
5151
.build();
5252

53-
val annotations = recommendations.stream().map(r -> convert(r, reportTitle))
53+
val annotations = recommendations.stream().map(r -> convert(r, reportTitle, url))
5454
.collect(Collectors.toList());
5555

5656
JSON_MAPPER.writeValue(outputDir.resolve(REPORT_FILE_NAME).toFile(), report);
5757
JSON_MAPPER.writeValue(outputDir.resolve(ANNOTATIONS_FILE_NAME).toFile(), annotations);
5858
}
5959

6060
private static CodeInsightsAnnotation convert(final RecommendationSummary recommendation,
61-
final String reportTitle) {
61+
final String reportTitle,
62+
final String url) {
6263
String description = recommendation.recommendationCategoryAsString();
6364
if (recommendation.ruleMetadata() != null) {
6465
description = recommendation.ruleMetadata().shortDescription();
@@ -70,6 +71,8 @@ private static CodeInsightsAnnotation convert(final RecommendationSummary recomm
7071
.path(recommendation.filePath())
7172
.line(recommendation.startLine())
7273
.summary(description)
74+
.details(recommendation.description())
75+
.link(url)
7376
.annotationType("Vulnerability".toUpperCase())
7477
.severity(convertSeverity(recommendation.severity()))
7578
.build();

0 commit comments

Comments
 (0)