From 70366497f19eb671a3ec4532ef7ad6e11d29f253 Mon Sep 17 00:00:00 2001 From: Martin Schaef Date: Tue, 22 Feb 2022 15:01:53 -0500 Subject: [PATCH 1/4] Update Main.java --- src/main/java/Main.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/main/java/Main.java b/src/main/java/Main.java index 566d973..2066a80 100644 --- a/src/main/java/Main.java +++ b/src/main/java/Main.java @@ -187,4 +187,11 @@ public void pathTraversal2(HttpServletRequest request) throws IOException { } } + + void formatStringNoncompliant(final File file) { + final long length = file.length(); + // Noncompliant: avoids using the correct format strings for their argument types. + final String s = format("File length is %s", length); + log.info(s); + } } From 5fc74e805f9780d5296e9b58c3868069ce7613fa Mon Sep 17 00:00:00 2001 From: Martin Schaef Date: Tue, 22 Feb 2022 15:07:03 -0500 Subject: [PATCH 2/4] Update Main.java --- src/main/java/Main.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/Main.java b/src/main/java/Main.java index 2066a80..7c9c872 100644 --- a/src/main/java/Main.java +++ b/src/main/java/Main.java @@ -192,6 +192,6 @@ void formatStringNoncompliant(final File file) { final long length = file.length(); // Noncompliant: avoids using the correct format strings for their argument types. final String s = format("File length is %s", length); - log.info(s); + System.out.println(s); } } From 94dcc5457dc530eacfb246a02d1de8c0f82a93a4 Mon Sep 17 00:00:00 2001 From: Martin Schaef Date: Tue, 22 Feb 2022 15:17:39 -0500 Subject: [PATCH 3/4] Update Main.java --- src/main/java/Main.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/Main.java b/src/main/java/Main.java index 7c9c872..bb94f54 100644 --- a/src/main/java/Main.java +++ b/src/main/java/Main.java @@ -191,7 +191,7 @@ public void pathTraversal2(HttpServletRequest request) throws IOException { void formatStringNoncompliant(final File file) { final long length = file.length(); // Noncompliant: avoids using the correct format strings for their argument types. - final String s = format("File length is %s", length); + final String s = String.format("File length is %s", length); System.out.println(s); } } From 4ec57aeea63f9ccf5010ff54027855dd347e2872 Mon Sep 17 00:00:00 2001 From: Martin Schaef Date: Tue, 22 Feb 2022 15:58:07 -0500 Subject: [PATCH 4/4] Update Main.java --- src/main/java/Main.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/Main.java b/src/main/java/Main.java index bb94f54..6fe8eba 100644 --- a/src/main/java/Main.java +++ b/src/main/java/Main.java @@ -5,6 +5,7 @@ import javax.servlet.http.HttpServletRequest; import javax.servlet.http.HttpServletResponse; import java.io.IOException; +import java.io.File; import java.io.UnsupportedEncodingException; import java.nio.ByteBuffer; import java.security.NoSuchAlgorithmException;