Skip to content

Commit 463996d

Browse files
committed
Rename short variable names to differentiate block vs body
- `B` -> `BlockExtra` - `BPtr` -> `BlockExtraPtr`
1 parent 4209b11 commit 463996d

File tree

2 files changed

+15
-15
lines changed

2 files changed

+15
-15
lines changed

core/types/block.libevm.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ func (h *Header) hooks() HeaderHooks {
4343
return new(NOOPHeaderHooks)
4444
}
4545

46-
func (e ExtraPayloads[HPtr, BPtr, SA]) hooksFromHeader(h *Header) HeaderHooks {
46+
func (e ExtraPayloads[HPtr, BlockExtraPtr, SA]) hooksFromHeader(h *Header) HeaderHooks {
4747
return e.Header.Get(h)
4848
}
4949

@@ -125,7 +125,7 @@ func (b *Block) hooks() BlockHooks {
125125
return new(NOOPBlockHooks)
126126
}
127127

128-
func (e ExtraPayloads[HPtr, BPtr, SA]) hooksFromBlock(b *Block) BlockHooks {
128+
func (e ExtraPayloads[HPtr, BlockExtraPtr, SA]) hooksFromBlock(b *Block) BlockHooks {
129129
return e.Block.Get(b)
130130
}
131131

core/types/rlp_payload.libevm.go

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -40,24 +40,24 @@ import (
4040
// [ExtraPayloads] returned by RegisterExtras. The default `SA` value accessed
4141
// in this manner will be a zero-value `SA` while the default value from a
4242
// [Header] is a non-nil `HPtr` and the default value from a [Block] is a non-nil
43-
// `BPtr`. The latter guarantee ensures that hooks won't be called on nil-pointer receivers.
43+
// `BlockExtraPtr`. The latter guarantee ensures that hooks won't be called on nil-pointer receivers.
4444
func RegisterExtras[
4545
H any, HPtr interface {
4646
HeaderHooks
4747
*H
4848
},
49-
B any, BPtr interface {
49+
BlockExtra any, BlockExtraPtr interface {
5050
BlockHooks
51-
*B
51+
*BlockExtra
5252
},
5353
SA any,
54-
]() ExtraPayloads[HPtr, BPtr, SA] {
55-
extra := ExtraPayloads[HPtr, BPtr, SA]{
54+
]() ExtraPayloads[HPtr, BlockExtraPtr, SA] {
55+
extra := ExtraPayloads[HPtr, BlockExtraPtr, SA]{
5656
Header: pseudo.NewAccessor[*Header, HPtr](
5757
(*Header).extraPayload,
5858
func(h *Header, t *pseudo.Type) { h.extra = t },
5959
),
60-
Block: pseudo.NewAccessor[*Block, BPtr](
60+
Block: pseudo.NewAccessor[*Block, BlockExtraPtr](
6161
(*Block).extraPayload,
6262
func(b *Block, t *pseudo.Type) { b.extra = t },
6363
),
@@ -71,11 +71,11 @@ func RegisterExtras[
7171
var x SA
7272
return fmt.Sprintf("%T", x)
7373
}(),
74-
// The [ExtraPayloads] that we returns is based on [HPtr,BPtr,SA], not [H,B,SA]
75-
// so our constructors MUST match that. This guarantees that calls to
74+
// The [ExtraPayloads] that we returns is based on [HPtr,BlockExtraPtr,SA], not
75+
// [H,BlockExtra,SA] so our constructors MUST match that. This guarantees that calls to
7676
// the [HeaderHooks] and [BlockHooks] methods will never be performed on a nil pointer.
77-
newHeader: pseudo.NewConstructor[H]().NewPointer, // i.e. non-nil HPtr
78-
newBlock: pseudo.NewConstructor[B]().NewPointer, // i.e. non-nil BPtr
77+
newHeader: pseudo.NewConstructor[H]().NewPointer, // i.e. non-nil HPtr
78+
newBlock: pseudo.NewConstructor[BlockExtra]().NewPointer, // i.e. non-nil BlockExtraPtr
7979
newStateAccount: pseudo.NewConstructor[SA]().Zero,
8080
cloneStateAccount: extra.cloneStateAccount,
8181
hooks: extra,
@@ -119,13 +119,13 @@ func (e *StateAccountExtra) clone() *StateAccountExtra {
119119
// ExtraPayloads provides strongly typed access to the extra payload carried by
120120
// [Header], [Block], [StateAccount], and [SlimAccount] structs. The only valid way to
121121
// construct an instance is by a call to [RegisterExtras].
122-
type ExtraPayloads[HPtr HeaderHooks, BPtr BlockHooks, SA any] struct {
122+
type ExtraPayloads[HPtr HeaderHooks, BlockExtraPtr BlockHooks, SA any] struct {
123123
Header pseudo.Accessor[*Header, HPtr]
124-
Block pseudo.Accessor[*Block, BPtr]
124+
Block pseudo.Accessor[*Block, BlockExtraPtr]
125125
StateAccount pseudo.Accessor[StateOrSlimAccount, SA] // Also provides [SlimAccount] access.
126126
}
127127

128-
func (ExtraPayloads[HPtr, BPtr, SA]) cloneStateAccount(s *StateAccountExtra) *StateAccountExtra {
128+
func (ExtraPayloads[HPtr, BlockExtraPtr, SA]) cloneStateAccount(s *StateAccountExtra) *StateAccountExtra {
129129
v := pseudo.MustNewValue[SA](s.t)
130130
return &StateAccountExtra{
131131
t: pseudo.From(v.Get()).Type,

0 commit comments

Comments
 (0)