From c91f9cc77ccfc49e45d39ef71cc79b1138417373 Mon Sep 17 00:00:00 2001 From: Sova <5620073+sergeysova@users.noreply.github.com> Date: Tue, 15 Aug 2023 14:11:36 +0300 Subject: [PATCH 1/2] improve type inference for `createRouteView` --- src/create-route-view.tsx | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/create-route-view.tsx b/src/create-route-view.tsx index 80831dc..2a6edbc 100644 --- a/src/create-route-view.tsx +++ b/src/create-route-view.tsx @@ -11,11 +11,8 @@ export interface RouteViewConfig { export function createRouteView< Props, - Params extends RouteParams, - Config extends { - [key in keyof RouteViewConfig]?: RouteViewConfig[key]; - } ->(config: Config) { + Params extends RouteParams +>(config: RouteViewConfig) { return (props: Props & Omit, keyof Config>) => { const mergedConfig = { ...config, ...props } as RouteViewConfig; const isOpened = useIsOpened(mergedConfig.route); From ff8297889aef56408050a25f82bea6dc814993f1 Mon Sep 17 00:00:00 2001 From: nothugofsea Date: Tue, 12 Dec 2023 04:53:41 +0300 Subject: [PATCH 2/2] Fixed types for createRouteView --- src/create-route-view.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/create-route-view.tsx b/src/create-route-view.tsx index 2a6edbc..8987674 100644 --- a/src/create-route-view.tsx +++ b/src/create-route-view.tsx @@ -13,7 +13,7 @@ export function createRouteView< Props, Params extends RouteParams >(config: RouteViewConfig) { - return (props: Props & Omit, keyof Config>) => { + return (props: Props & Omit, keyof typeof config>) => { const mergedConfig = { ...config, ...props } as RouteViewConfig; const isOpened = useIsOpened(mergedConfig.route);