✨ feat: Add multi-threaded socket acceptor and initiator support #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename SocketAcceptor to Acceptor, and SocketInitator to Initator. The idea is to provide support for Threaded version of this classes. BREAKING CHANGE: 🧨 API Change
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
- Coverage 92.73% 92.58% -0.16%
==========================================
Files 38 38
Lines 2162 2063 -99
Branches 2162 2063 -99
==========================================
- Hits 2005 1910 -95
+ Misses 85 82 -3
+ Partials 72 71 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add experimental support for
ThreadedSocketAcceptorandThreadedSocketInitiator.This implementation are available through
experimental-multi-thread-supportfeature flag onquickfixcrate.This PR introduce breaking changes in quickfix library API.
Related issues: #25