From 6dfe80f284309b8c3a529b9b5050116751c88f52 Mon Sep 17 00:00:00 2001 From: Prithwish Mukherjee Date: Thu, 12 Jun 2025 10:13:47 +0530 Subject: [PATCH 1/2] chore: Activate 'get_state' test for 'test_settings_with_deprecated_flag' --- tests/test_settings_api.py | 25 ++++++++++++------------- 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/tests/test_settings_api.py b/tests/test_settings_api.py index 7b4b66152fed..85343d6aefbd 100644 --- a/tests/test_settings_api.py +++ b/tests/test_settings_api.py @@ -705,20 +705,19 @@ def test_settings_with_deprecated_flag(mixing_elbow_settings_session): # User won't normally find deprecated objects in the settings API, so it is OK to leave them active. assert graphics.contour["contour-velocity"].range_options.is_active() - # https://github.com/ansys/pyfluent/issues/3813 # in 'get_state' - # if solver.get_fluent_version() >= FluentVersion.v252: - # # From v252 'get_state' behaviour is to be corrected in Fluent. - # assert not {"range_option", "coloring"}.issubset( - # set(graphics.contour["contour-velocity"].get_state()) - # ) - # assert {"range_options", "colorings"}.issubset( - # set(graphics.contour["contour-velocity"].get_state()) - # ) - # else: - # assert {"range_option", "range_options", "coloring", "colorings"}.issubset( - # set(graphics.contour["contour-velocity"].get_state()) - # ) + if solver.get_fluent_version() >= FluentVersion.v252: + # From v252 'get_state' behaviour is to be corrected in Fluent. + assert not {"range_option", "coloring"}.issubset( + set(graphics.contour["contour-velocity"].get_state()) + ) + assert {"range_options", "colorings"}.issubset( + set(graphics.contour["contour-velocity"].get_state()) + ) + else: + assert {"range_option", "range_options", "coloring", "colorings"}.issubset( + set(graphics.contour["contour-velocity"].get_state()) + ) # in 'child_names' # 'child_names', 'command_names' and 'query_names' will remain unchanged. From de729ec7fbad423808ad673402fa5bbdc97815cc Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Thu, 12 Jun 2025 04:45:31 +0000 Subject: [PATCH 2/2] chore: adding changelog file 4147.maintenance.md [dependabot-skip] --- doc/changelog.d/4147.maintenance.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/changelog.d/4147.maintenance.md diff --git a/doc/changelog.d/4147.maintenance.md b/doc/changelog.d/4147.maintenance.md new file mode 100644 index 000000000000..adaa93bd67e0 --- /dev/null +++ b/doc/changelog.d/4147.maintenance.md @@ -0,0 +1 @@ +Activate 'get_state' test for 'test_settings_with_deprecated_flag' \ No newline at end of file