From 86e00c2638fd580743d610c2a312a5919835a9e2 Mon Sep 17 00:00:00 2001
From: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Date: Sat, 16 Dec 2023 16:31:40 +0000
Subject: [PATCH] vuln-fix: Use HTTPS instead of HTTP to resolve deps
 CVE-2021-26291

This fixes a security vulnerability in this project where the `pom.xml`
files were configuring Maven to resolve dependencies over HTTP instead of
HTTPS.

Weakness: CWE-829: Inclusion of Functionality from Untrusted Control Sphere
Severity: High
CVSS: 8.1
Detection: CodeQL & OpenRewrite (https://app.moderne.io/recipes/org.openrewrite.maven.security.UseHttpsForRepositories)

Reported-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/8
Detection: CodeQL (https://codeql.github.com/codeql-query-help/java/java-maven-non-https-url/) & OpenRewrite (https://app.moderne.io/recipes/org.openrewrite.maven.security.UseHttpsForRepositories)

Reported-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>
Signed-off-by: Jonathan Leitschuh <Jonathan.Leitschuh@gmail.com>

Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/8


Use this link to re-run the recipe: https://app.moderne.io/recipes/builder/IfHkrYfxx?organizationId=QWxsIEdpdEh1Yg%3D%3D

Co-authored-by: Moderne <team@moderne.io>
---
 priceline/dar/pom.xml |  2 +-
 priceline/pom.xml     | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/priceline/dar/pom.xml b/priceline/dar/pom.xml
index db47f0c..2579336 100644
--- a/priceline/dar/pom.xml
+++ b/priceline/dar/pom.xml
@@ -18,7 +18,7 @@
 </pluginRepository>
 <pluginRepository>
   <id>knopflerfish</id>
-  <url>http://www.knopflerfish.org/maven2</url>
+  <url>https://www.knopflerfish.org/maven2</url>
 </pluginRepository>
 </pluginRepositories>
 
diff --git a/priceline/pom.xml b/priceline/pom.xml
index afffc64..f235440 100644
--- a/priceline/pom.xml
+++ b/priceline/pom.xml
@@ -46,11 +46,11 @@
   <distributionManagement>
     <repository>
       <id>central</id>
-      <url>http://maven:8082/nexus/content/repositories/libs-releases-local</url>
+      <url>https://maven:8082/nexus/content/repositories/libs-releases-local</url>
     </repository>
     <snapshotRepository>
       <id>snapshots</id>
-      <url>http://maven:8082/nexus/content/repositories/libs-snapshots-local</url>
+      <url>https://maven:8082/nexus/content/repositories/libs-snapshots-local</url>
     </snapshotRepository>
   </distributionManagement>
   <properties>
@@ -76,28 +76,28 @@
         <enabled>true</enabled>
       </snapshots>
       <id>central</id>
-      <url>http://maven:8082/nexus/content/groups/repo</url>
+      <url>https://maven:8082/nexus/content/groups/repo</url>
     </repository>
     <repository>
       <snapshots>
         <enabled>true</enabled>
       </snapshots>
       <id>plugins-releases-local</id>
-      <url>http://maven:8082/nexus/content/repositories/plugins-releases-local</url>
+      <url>https://maven:8082/nexus/content/repositories/plugins-releases-local</url>
     </repository>
     <repository>
       <releases>
         <enabled>true</enabled>
       </releases>
       <id>snapshots</id>
-      <url>http://maven:8082/nexus/content/groups/repo</url>
+      <url>https://maven:8082/nexus/content/groups/repo</url>
     </repository>
     <repository>
       <releases>
         <enabled>true</enabled>
       </releases>
       <id>snapshots1</id>
-      <url>http://maven:8082/nexus/content/repositories/ext-snapshots-local</url>
+      <url>https://maven:8082/nexus/content/repositories/ext-snapshots-local</url>
     </repository>
   </repositories>
   <!--<pluginRepositories>