Skip to content

Commit 97087d2

Browse files
author
craig
committed
1.0.3 / 2021-07-21
================== * Breaking change to boot function parameter to pass a context object, oh well early days - @craigparra * Refactor loggerRegistry to LoggerCategoryCache - @craigparra
1 parent 2d0f502 commit 97087d2

File tree

5 files changed

+34
-24
lines changed

5 files changed

+34
-24
lines changed

History.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,9 @@
1+
1.0.3 / 2021-07-21
2+
==================
3+
4+
* Breaking change to boot function parameter to pass a context object, oh well early days - @craigparra
5+
* Refactor loggerRegistry to LoggerCategoryCache - @craigparra
6+
17
1.0.2 / 2021-07-21
28
==================
39

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ const {config} = require('@alt-javascript/config');
2929
const {LoggerFactory} = require('@alt-javascript/logger');
3030
const {boot} = require('@alt-javascript/boot');
3131

32-
boot(config);
32+
boot({config:config});
3333

3434
config.get('key');
3535
config.get('nested.key');
@@ -49,7 +49,7 @@ const winston = require('winston');
4949
const {LoggerFactory, WinstonLoggerFactory} = require('@alt-javascript/logger');
5050
const {boot} = require('@alt-javascript/boot');
5151
const winstonLoggerFactory = new WinstonLoggerFactory(config,winston,{/*my winston options*/})
52-
boot(config, winstonLoggerFactory);
52+
boot({config:config, loggerFactory:winstonLoggerFactory});
5353
```
5454

5555
Then in your application modules, you only need.

boot.js

Lines changed: 14 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
const {ValueResolvingConfig,EphemeralConfig,ConfigFactory} = require ('@alt-javascript/config');
2-
const {LoggerRegistry,LoggerFactory,ConfigurableLogger} = require('@alt-javascript/logger');
2+
const {LoggerCategoryCache,LoggerFactory,ConfigurableLogger} = require('@alt-javascript/logger');
33

4-
module.exports = function (configArg,loggerFactoryArg,loggerRegistryArg) {
4+
module.exports = function (context) {
5+
6+
let configArg = context?.config;
7+
let loggerFactoryArg = context?.loggerFactory;
8+
let loggerCategoryCacheArg = context?.loggerFactory;
59

610
let browser = !(typeof window == 'undefined');
711

@@ -27,21 +31,21 @@ module.exports = function (configArg,loggerFactoryArg,loggerRegistryArg) {
2731
throw new Error ('Unable to detect config, is \'config\' declared or provided?');
2832
}
2933

30-
let _loggerRegistry = null;
31-
if (!(typeof loggerRegistry == 'undefined')){
32-
_loggerRegistry = loggerRegistry;
34+
let _loggerCategoryCache = null;
35+
if (!(typeof loggerCategoryCacheArg == 'undefined')){
36+
_loggerCategoryCache = loggerCategoryCacheArg;
3337
}
34-
if (browser && window?.loggerRegistry){
35-
_config = window.loggerRegistry;
38+
if (browser && window?.loggerCategoryCache){
39+
_config = window.loggerCategoryCache;
3640
}
3741

38-
_loggerRegistry = _loggerRegistry || loggerRegistryArg || new LoggerRegistry();
42+
_loggerCategoryCache = _loggerCategoryCache || loggerCategoryCacheArg || new LoggerCategoryCache();
3943

4044
let _loggerFactory = null;
4145
if (!(typeof loggerFactory == 'undefined')){
4246
_loggerFactory = loggerFactory;
4347
}
44-
_loggerFactory = _loggerFactory || loggerFactoryArg || new LoggerFactory(_config,_loggerRegistry,ConfigurableLogger.DEFAULT_CONFIG_PATH);
48+
_loggerFactory = _loggerFactory || loggerFactoryArg || new LoggerFactory(_config,_loggerCategoryCache,ConfigurableLogger.DEFAULT_CONFIG_PATH);
4549

4650
let _globalref = null;
4751
if (browser){
@@ -50,7 +54,7 @@ module.exports = function (configArg,loggerFactoryArg,loggerRegistryArg) {
5054
_globalref = global;
5155
}
5256
_globalref.boot = {contexts: {root:{config:_config}}};
53-
_globalref.boot.contexts.root.loggerRegistry = _loggerRegistry;
57+
_globalref.boot.contexts.root.loggerCategoryCache = _loggerCategoryCache;
5458
_globalref.boot.contexts.root.loggerFactory = _loggerFactory;
5559

5660
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@alt-javascript/boot",
3-
"version": "1.0.2",
3+
"version": "1.0.3",
44
"description": "An Extensible Config & Logging Application Bootstrap Function",
55
"author": "Craig Parravicini",
66
"keywords": ["logging","configuration","boostrap","boot","global","context"],

test/boot.spec.js

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ const config = require('config');
33
const altConfig = require('@alt-javascript/config').config;
44
const {EphemeralConfig,ConfigFactory,ValueResolvingConfig} = require('@alt-javascript/config');
55
const {boot} = require('..');
6-
const {CachingLoggerFactory,LoggerFactory,LoggerRegistry} = require('@alt-javascript/logger');
6+
const {CachingLoggerFactory,LoggerFactory,LoggerCategoryCache} = require('@alt-javascript/logger');
77
const logger = LoggerFactory.getLogger('@alt-javascript/boot/test/boot_spec',config);
88

99
before(async () => {
@@ -36,18 +36,18 @@ describe('boot function', () => {
3636
});
3737
it('boot - config ', () => {
3838
const config = new EphemeralConfig({});
39-
boot(config);
39+
boot({config:config});
4040
assert.instanceOf(global.boot.contexts.root.config,ValueResolvingConfig,'global.boot.contexts.root.config instanceof ValueResolvingConfig');
4141
assert.instanceOf(global.boot.contexts.root.loggerFactory,LoggerFactory,'global.boot.contexts.root.loggerFactory instanceof LoggerFactory');
42-
assert.instanceOf(global.boot.contexts.root.loggerRegistry,LoggerRegistry,'global.boot.contexts.root.loggerRegistry instanceof loggerRegistry');
42+
assert.instanceOf(global.boot.contexts.root.loggerCategoryCache,LoggerCategoryCache,'global.boot.contexts.root.loggerCategoryCache instanceof loggerCategoryCache');
4343
global.boot = undefined;
4444
});
4545
it('boot - config with ValueResolvingConfig ', () => {
4646
const config = ConfigFactory.getConfig(new EphemeralConfig({})) ;
47-
boot(config);
47+
boot({config:config});
4848
assert.instanceOf(global.boot.contexts.root.config,ValueResolvingConfig,'global.boot.contexts.root.config instanceof ValueResolvingConfig');
4949
assert.instanceOf(global.boot.contexts.root.loggerFactory,LoggerFactory,'global.boot.contexts.root.loggerFactory instanceof LoggerFactory');
50-
assert.instanceOf(global.boot.contexts.root.loggerRegistry,LoggerRegistry,'global.boot.contexts.root.loggerRegistry instanceof loggerRegistry');
50+
assert.instanceOf(global.boot.contexts.root.loggerCategoryCache,LoggerCategoryCache,'global.boot.contexts.root.loggerCategoryCache instanceof loggerCategoryCache');
5151
global.boot = undefined;
5252
});
5353

@@ -57,7 +57,7 @@ describe('boot function', () => {
5757
boot();
5858
assert.instanceOf(global.boot.contexts.root.config,ValueResolvingConfig,'global.boot.contexts.root.config instanceof ValueResolvingConfig');
5959
assert.instanceOf(global.boot.contexts.root.loggerFactory,LoggerFactory,'global.boot.contexts.root.loggerFactory instanceof LoggerFactory');
60-
assert.instanceOf(global.boot.contexts.root.loggerRegistry,LoggerRegistry,'global.boot.contexts.root.loggerRegistry instanceof loggerRegistry');
60+
assert.instanceOf(global.boot.contexts.root.loggerCategoryCache,LoggerCategoryCache,'global.boot.contexts.root.loggerCategoryCache instanceof loggerCategoryCache');
6161
global.boot = undefined;
6262
global.config = undefined;
6363
});
@@ -68,16 +68,16 @@ describe('boot function', () => {
6868
boot();
6969
assert.instanceOf(global.window.boot.contexts.root.config,ValueResolvingConfig,'global.boot.contexts.root.config instanceof ValueResolvingConfig');
7070
assert.instanceOf(global.window.boot.contexts.root.loggerFactory,LoggerFactory,'global.boot.contexts.root.loggerFactory instanceof LoggerFactory');
71-
assert.instanceOf(global.window.boot.contexts.root.loggerRegistry,LoggerRegistry,'global.boot.contexts.root.loggerRegistry instanceof loggerRegistry');
71+
assert.instanceOf(global.window.boot.contexts.root.loggerCategoryCache,LoggerCategoryCache,'global.boot.contexts.root.loggerCategoryCache instanceof loggerCategoryCache');
7272
global.boot = undefined;
7373
global.window = undefined;
7474
});
7575

7676
it('boot - LoggerFactory detects boot root context', () => {
7777
const config = new EphemeralConfig({logging:{level:{'/': 'info'}}});
78-
const cachingLoggerFactory = new CachingLoggerFactory(config, new LoggerRegistry());
78+
const cachingLoggerFactory = new CachingLoggerFactory(config, new LoggerCategoryCache());
7979

80-
boot(config,cachingLoggerFactory);
80+
boot({config:config,loggerFactory:cachingLoggerFactory});
8181
const logger = LoggerFactory.getLogger('@alt-javascript/boot/test/boot_spec')
8282

8383
logger.info('message');
@@ -87,8 +87,8 @@ describe('boot function', () => {
8787
});
8888

8989
it('boot - uses config local-development', () => {
90-
const cachingLoggerFactory = new CachingLoggerFactory(config, new LoggerRegistry());
91-
boot(config,cachingLoggerFactory);
90+
const cachingLoggerFactory = new CachingLoggerFactory(config, new LoggerCategoryCache());
91+
boot({config:config,loggerFactory:cachingLoggerFactory});
9292
const logger = LoggerFactory.getLogger('@alt-javascript/boot/test/boot_spec/local-development')
9393

9494
logger.debug('message');

0 commit comments

Comments
 (0)