Merge pull request #20 from advanced-rest-client/fix/W-17655986/Exchange-asset-is-not-able-to-pass-ValueOnly-False-in-the-request

Fix/W-17655986/exchange asset is not able to pass value only false in the request

Author: alexpmule

.github/workflows/deployment.yml

@@ -13,8 +13,12 @@ on:
       - main
 jobs:
   test_linux:
-    name: ubuntu
-    runs-on: ubuntu-latest
+    name: ${{ matrix.os }}
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-20.04]
+    runs-on: ${{ matrix.os }}
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1
@@ -53,7 +57,7 @@ jobs:
   tag:
     name: "Publishing release"
     if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/master'
-    needs: 
+    needs:
       - test_linux
       - test_win
     runs-on: ubuntu-latest

package-lock.json

@@ -1,7 +1,7 @@
 {
   "name": "@api-components/api-url",
   "description": "A library containing helper classes and UIs to support URL editing in AMF powered URL editor.",
-  "version": "0.1.18",
+  "version": "0.1.20",
   "license": "Apache-2.0",
   "main": "index.js",
   "module": "index.js",

package.json

@@ -326,7 +326,7 @@ export class ApiUrlEditorElement extends EventsTargetMixin(ValidatableMixin(LitE
     await this.updateComplete;
     this.validate();
   }
-  
+
   /**
    * Creates a map of serialized values from a model.
    * It is a replacement for `iron-form` serialize function which
@@ -349,11 +349,12 @@ export class ApiUrlEditorElement extends EventsTargetMixin(ValidatableMixin(LitE
     });
     return result;
   }
-  
+
   /**
    * Extracts value from the model item.
-   * If the item is required it is always returned (even  if it is empty string).
+   * If the item is required it is always returned (even if it is an empty string).
    * If value is not required and not present then it returns `undefined`.
+   * Ensures boolean values are correctly preserved.
    *
    * @param {AmfFormItem} item Model item
    * @return {string} Model value
@@ -362,8 +363,14 @@ export class ApiUrlEditorElement extends EventsTargetMixin(ValidatableMixin(LitE
     if (item.schema && item.enabled === false) {
       return undefined;
     }
-    const { schema={} } = item;
+
+    const { schema = {} } = item;
     let { value } = item;
+
+    if (schema.isBool) {
+      return value === false ? "false" : "true";
+    }
+
     if (!value && schema.required) {
       if (value !== 0 && value !== false && value !== null) {
         value = '';
@@ -373,6 +380,7 @@ export class ApiUrlEditorElement extends EventsTargetMixin(ValidatableMixin(LitE
         value = undefined;
       }
     }
+
     return value;
   }
 
@@ -421,7 +429,7 @@ export class ApiUrlEditorElement extends EventsTargetMixin(ValidatableMixin(LitE
     }
     return new RegExp(`{${name}}`);
   }
-  
+
   /**
    * Applies query parameters to the URL.
    * Query parameters that are not required by the API spec and don't have value
@@ -489,7 +497,7 @@ export class ApiUrlEditorElement extends EventsTargetMixin(ValidatableMixin(LitE
   }
 
   /**
-   * @param {ParamsObject[]} object The list of objects to encode as x-www-form-urlencoded string. 
+   * @param {ParamsObject[]} object The list of objects to encode as x-www-form-urlencoded string.
    * Each entry should have `name` and `value` properties.
    * @returns {string}
    */
@@ -502,7 +510,7 @@ export class ApiUrlEditorElement extends EventsTargetMixin(ValidatableMixin(LitE
     });
     return pieces.join('&');
   }
-  
+
   /**
    * @param {string|number} value A key or value to encode as x-www-form-urlencoded.
    * @param {boolean} replacePlus When set it replaces `%20` with `+`.
@@ -572,7 +580,7 @@ export class ApiUrlEditorElement extends EventsTargetMixin(ValidatableMixin(LitE
       obj[name] = parts[1];
     }
   }
-  
+
   /**
    * Applies values from the `values` array to the uri parameters which names are in the `names` array.
    * Both lists are ordered list of parameters.

src/ApiUrlEditorElement.js

@@ -7,35 +7,35 @@ import { UrlEventTypes } from '../index.js';
 
 describe('ApiUrlEditorElement', () => {
   /**
-   * @return {Promise<ApiUrlEditorElement>} 
+   * @return {Promise<ApiUrlEditorElement>}
    */
   async function basicFixture() {
     return (fixture(html`<api-url-editor></api-url-editor>`));
   }
 
   /**
-   * @return {Promise<ApiUrlEditorElement>} 
+   * @return {Promise<ApiUrlEditorElement>}
    */
   async function requiredFixture() {
     return (fixture(html`<api-url-editor required></api-url-editor>`));
   }
 
   /**
-   * @return {Promise<ApiUrlEditorElement>} 
+   * @return {Promise<ApiUrlEditorElement>}
    */
   async function eventsFixture() {
     return (fixture(html`<api-url-editor baseUri="https://domain.com" endpointPath="/{path}"></api-url-editor>`));
   }
 
   /**
-   * @return {Promise<ApiUrlEditorElement>} 
+   * @return {Promise<ApiUrlEditorElement>}
    */
   async function valueFixture() {
     return (fixture(html`<api-url-editor value="https://domain.com/api/path"></api-url-editor>`));
   }
 
   /**
-   * @return {Promise<ApiUrlEditorElement>} 
+   * @return {Promise<ApiUrlEditorElement>}
    */
   async function invalidFixture() {
     return (fixture(html`<api-url-editor value="https://domain.com/{path}" invalid></api-url-editor>`));
@@ -110,6 +110,50 @@ describe('ApiUrlEditorElement', () => {
     });
   });
 
+  describe('Boolean values in query parameters', () => {
+    let element = /** @type ApiUrlEditorElement */ (null);
+    let queryModel;
+    const TEST_PATH = '/path/{var}';
+
+    beforeEach(async () => {
+      element = await basicFixture();
+      element.baseUri = BASE_URI;
+      element.endpointPath = TEST_PATH;
+      queryModel = [
+        {
+          value: false,
+          name: 'test1',
+          schema: {
+            required: true,
+            inputType: 'boolean',
+            isBool: true
+          }
+        },
+        {
+          value: true,
+          name: 'test2',
+          schema: {
+            required: true,
+            inputType: 'boolean',
+            isBool: true
+          }
+        }
+      ];
+    });
+
+    it('includes boolean false as a query parameter in the URL', () => {
+      element.queryModel = queryModel;
+      const match = element.value.match(/test1=false/g);
+      assert.equal(match.length, 1, 'Boolean false should be included in the URL as "test1=false"');
+    });
+
+    it('includes boolean true as a query parameter in the URL', () => {
+      element.queryModel = queryModel;
+      const match = element.value.match(/&test2=true/g);
+      assert.equal(match.length, 1, 'Boolean true should be included in the URL as "&test2=true"');
+    });
+  });
+
   describe('Dispatches events', () => {
     let element = /** @type ApiUrlEditorElement */ (null);
     let queryModel;
@@ -902,4 +946,6 @@ describe('ApiUrlEditorElement', () => {
       assert.equal(url, '/flights/');
     });
   });
+
+
 });