Skip to content
This repository was archived by the owner on Feb 15, 2024. It is now read-only.

Commit 97882cb

Browse files
authored
Merge pull request #22 from Daespen/feature/test-core
Feature/test core
2 parents 16f4d1a + a83f389 commit 97882cb

File tree

49 files changed

+430
-4639
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+430
-4639
lines changed

dataformat-aasx/pom.xml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,13 @@
1717
<version>${revision}</version>
1818
<scope>compile</scope>
1919
</dependency>
20+
<dependency>
21+
<groupId>io.admin-shell.aas</groupId>
22+
<artifactId>dataformat-core</artifactId>
23+
<version>${revision}</version>
24+
<classifier>tests</classifier>
25+
<scope>test</scope>
26+
</dependency>
2027
<dependency>
2128
<groupId>io.admin-shell.aas</groupId>
2229
<artifactId>model</artifactId>

dataformat-aasx/src/main/java/io/adminshell/aas/v3/dataformat/aasx/AASXDeserializer.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import java.io.IOException;
1919
import java.io.InputStream;
2020
import java.io.StringWriter;
21-
import java.nio.charset.StandardCharsets;
2221
import java.util.ArrayList;
2322
import java.util.Collection;
2423
import java.util.List;
@@ -31,6 +30,7 @@
3130
import org.apache.poi.openxml4j.opc.PackagingURIHelper;
3231

3332
import io.adminshell.aas.v3.dataformat.DeserializationException;
33+
import io.adminshell.aas.v3.dataformat.Serializer;
3434
import io.adminshell.aas.v3.dataformat.xml.XmlDeserializer;
3535
import io.adminshell.aas.v3.model.AssetAdministrationShellEnvironment;
3636
import io.adminshell.aas.v3.model.File;
@@ -125,7 +125,7 @@ private String getXMLResourceString(OPCPackage aasxPackage) throws InvalidFormat
125125
// Read the content from the PackagePart
126126
InputStream stream = xmlPart.getInputStream();
127127
StringWriter writer = new StringWriter();
128-
IOUtils.copy(stream, writer, StandardCharsets.UTF_8);
128+
IOUtils.copy(stream, writer, Serializer.DEFAULT_CHARSET);
129129
return writer.toString();
130130
}
131131

dataformat-aasx/src/main/java/io/adminshell/aas/v3/dataformat/aasx/AASXSerializer.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public void write(AssetAdministrationShellEnvironment environment, Collection<In
101101
String xml = xmlSerializer.write(environment);
102102

103103
// Save the XML to aasx/xml/content.xml
104-
PackagePart xmlPart = createAASXPart(rootPackage, origin, XML_PATH, MIME_XML, AASSPEC_RELTYPE, xml.getBytes());
104+
PackagePart xmlPart = createAASXPart(rootPackage, origin, XML_PATH, MIME_XML, AASSPEC_RELTYPE, xml.getBytes(Serializer.DEFAULT_CHARSET));
105105

106106
storeFilesInAASX(environment.getSubmodels(), files, rootPackage, xmlPart);
107107

dataformat-aasx/src/test/java/io/adminshell/aas/v3/dataformat/aasx/deserialization/AASXDeserializerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838
import io.adminshell.aas.v3.dataformat.aasx.AASXDeserializer;
3939
import io.adminshell.aas.v3.dataformat.aasx.AASXSerializer;
4040
import io.adminshell.aas.v3.dataformat.aasx.InMemoryFile;
41-
import io.adminshell.aas.v3.dataformat.aasx.serialization.AASSimple;
41+
import io.adminshell.aas.v3.dataformat.core.AASSimple;
4242

4343
public class AASXDeserializerTest {
4444

dataformat-aasx/src/test/java/io/adminshell/aas/v3/dataformat/aasx/deserialization/ValidationTest.java

Lines changed: 17 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -16,26 +16,30 @@
1616
package io.adminshell.aas.v3.dataformat.aasx.deserialization;
1717

1818
import static org.junit.Assert.assertEquals;
19-
import static org.junit.Assert.assertNull;
2019

21-
import io.adminshell.aas.v3.dataformat.DeserializationException;
22-
import io.adminshell.aas.v3.dataformat.SerializationException;
23-
import io.adminshell.aas.v3.dataformat.aasx.AASXDeserializer;
24-
import io.adminshell.aas.v3.dataformat.aasx.AASXSerializer;
25-
import io.adminshell.aas.v3.dataformat.aasx.AASXValidator;
26-
import io.adminshell.aas.v3.dataformat.aasx.InMemoryFile;
27-
import io.adminshell.aas.v3.dataformat.aasx.serialization.AASSimple;
20+
import java.io.File;
21+
import java.io.FileInputStream;
22+
import java.io.FileOutputStream;
23+
import java.io.IOException;
24+
import java.io.InputStream;
25+
import java.util.ArrayList;
26+
import java.util.List;
27+
import java.util.Set;
28+
29+
import javax.xml.parsers.ParserConfigurationException;
30+
2831
import org.apache.poi.openxml4j.exceptions.InvalidFormatException;
2932
import org.junit.Rule;
3033
import org.junit.Test;
3134
import org.junit.rules.TemporaryFolder;
3235
import org.xml.sax.SAXException;
3336

34-
import javax.xml.parsers.ParserConfigurationException;
35-
import java.io.*;
36-
import java.util.ArrayList;
37-
import java.util.List;
38-
import java.util.Set;
37+
import io.adminshell.aas.v3.dataformat.DeserializationException;
38+
import io.adminshell.aas.v3.dataformat.SerializationException;
39+
import io.adminshell.aas.v3.dataformat.aasx.AASXSerializer;
40+
import io.adminshell.aas.v3.dataformat.aasx.AASXValidator;
41+
import io.adminshell.aas.v3.dataformat.aasx.InMemoryFile;
42+
import io.adminshell.aas.v3.dataformat.core.AASSimple;
3943

4044
public class ValidationTest {
4145

dataformat-aasx/src/test/java/io/adminshell/aas/v3/dataformat/aasx/serialization/AASSimple.java

Lines changed: 0 additions & 183 deletions
This file was deleted.

dataformat-aasx/src/test/java/io/adminshell/aas/v3/dataformat/aasx/serialization/AASXSerializerTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
*/
1616
package io.adminshell.aas.v3.dataformat.aasx.serialization;
1717

18+
1819
import static org.junit.Assert.assertEquals;
1920
import static org.junit.Assert.assertTrue;
2021

@@ -35,6 +36,7 @@
3536
import io.adminshell.aas.v3.dataformat.SerializationException;
3637
import io.adminshell.aas.v3.dataformat.aasx.AASXSerializer;
3738
import io.adminshell.aas.v3.dataformat.aasx.InMemoryFile;
39+
import io.adminshell.aas.v3.dataformat.core.AASSimple;
3840

3941
public class AASXSerializerTest {
4042

0 commit comments

Comments
 (0)