Skip to content

fix(undefind http) #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(undefind http) #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added products/zillion/bun.lockb
View file
Open in desktop
Binary file not shown.
54 changes: 27 additions & 27 deletions products/zillion/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,27 +7,27 @@
"@ledgerhq/hw-transport-u2f": "^5.36.0-deprecated",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not update the package version. We are moving out of Zillion to a new staking platform, so the focus is on keeping it working till then. Updating packages always creates a risk of new bugs materializing.

"@ledgerhq/hw-transport-webhid": "^5.51.1",
"@ledgerhq/hw-transport-webusb": "^5.53.1",
"@reduxjs/toolkit": "^1.6.0",
"@tippyjs/react": "^4.2.0",
"@reduxjs/toolkit": "^1.9.7",
"@tippyjs/react": "^4.2.6",
"@zilliqa-js/zilliqa": "^3.5.0",
"bignumber.js": "^9.0.0",
"bootstrap": "^4.5.2",
"jquery": "^3.5.1",
"bignumber.js": "^9.3.0",
"bootstrap": "^4.6.2",
"jquery": "^3.7.1",
"popper.js": "1.16.1",
"random-js": "^2.1.0",
"react": "^17.0.2",
"react-animated-numbers": "^0.1.0",
"react-dom": "^17.0.2",
"react-promise-tracker": "^2.1.0",
"react-redux": "^7.2.4",
"react-router-dom": "^5.2.0",
"react-promise-tracker": "^2.1.1",
"react-redux": "^7.2.9",
"react-router-dom": "^5.3.4",
"react-scripts": "3.4.3",
"react-table": "^7.7.0",
"react-tabs": "^3.2.2",
"react-toastify": "^6.0.8",
"react-tooltip": "^4.2.10",
"redux-saga": "^1.1.3",
"tslib": "^2.0.1"
"react-table": "^7.8.0",
"react-tabs": "^3.2.3",
"react-toastify": "^6.2.0",
"react-tooltip": "^4.5.1",
"redux-saga": "^1.3.0",
"tslib": "^2.8.1"
},
"scripts": {
"start": "react-scripts start",
Expand All @@ -54,18 +54,18 @@
]
},
"devDependencies": {
"@types/bootstrap": "^4.5.0",
"@types/jquery": "^3.5.1",
"@types/ledgerhq__hw-transport": "^4.21.3",
"@types/ledgerhq__hw-transport-u2f": "^4.21.2",
"@types/node": "^12.12.54",
"@types/react": "^16.9.46",
"@types/react-dom": "^16.9.8",
"@types/react-redux": "^7.1.16",
"@types/react-router-dom": "^5.1.5",
"@types/react-select": "^3.0.19",
"@types/react-table": "^7.0.22",
"@types/react-tabs": "^2.3.2",
"typescript": "^3.9.7"
"@types/bootstrap": "^4.6.6",
"@types/jquery": "^3.5.32",
"@types/ledgerhq__hw-transport": "^4.21.8",
"@types/ledgerhq__hw-transport-u2f": "^4.21.5",
"@types/node": "^12.20.55",
"@types/react": "^16.14.65",
"@types/react-dom": "^16.9.25",
"@types/react-redux": "^7.1.34",
"@types/react-router-dom": "^5.3.3",
"@types/react-select": "^3.1.2",
"@types/react-table": "^7.7.20",
"@types/react-tabs": "^2.3.4",
"typescript": "^3.9.10"
}
}
2 changes: 1 addition & 1 deletion products/zillion/public/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ window['config'] = {
api_list : [
"https://api.zilliqa.com",
"https://ssn-zilliqa.cex.io/api",
// "https://ssn.ignitedao.io/api",
"https://ssn.ignitedao.io/api",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This API was commented out because it was not working properly. Have you checked that it works now?

"https://ssn.zillet.io",
"https://zil-staking.ezil.me/api",
"https://staking-zil.kucoin.com/api",
Expand Down
6 changes: 5 additions & 1 deletion products/zillion/src/app.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2067,4 +2067,8 @@ input:focus {

.cover-img{
object-fit: cover;
}
}

iframe {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed?

z-index: -1 !important;
}
4 changes: 2 additions & 2 deletions products/zillion/src/components/dashboard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ function Dashboard(props: any) {

if (zilPay) {
networkChanger(
tryGetNetworkLabelByApiUrl(zilPay.wallet.http) || zilPay.wallet.net
Boolean(zilPay.wallet.http) ? tryGetNetworkLabelByApiUrl(zilPay.wallet.http) : zilPay.wallet.net
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
Boolean(zilPay.wallet.http) ? tryGetNetworkLabelByApiUrl(zilPay.wallet.http) : zilPay.wallet.net
!!zilPay.wallet.http ? tryGetNetworkLabelByApiUrl(zilPay.wallet.http) : zilPay.wallet.net

);

const accountStreamChanged = zilPay.wallet.observableAccount().subscribe((account: any) => {
Expand Down Expand Up @@ -575,4 +575,4 @@ function Dashboard(props: any) {
);
}

export default Dashboard;
export default Dashboard;