Skip to content
This repository was archived by the owner on Aug 3, 2021. It is now read-only.

chore : fix typo in chapter 1 #162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vinhyenvodoi98
Copy link

when I tried learning scilla I saw a couple of typo mistakes and fixed it.

@vinhyenvodoi98 vinhyenvodoi98 force-pushed the fixTypo branch 2 times, most recently from b7cfad5 to a56c1d0 Compare November 6, 2020 03:27
@bb111189
Copy link
Contributor

h @vinhyenvodoi98 ,

Thanks for your PR. The semi-colon (;) is necessary for statements separation. Only the final statement does not have a trailing ;
https://scilla.readthedocs.io/en/latest/scilla-in-depth.html#statements

Copy link
Contributor

@bb111189 bb111189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semi-colon should not be removed

@vinhyenvodoi98
Copy link
Author

@bb111189 oh i got it
I have returned the semicolon needed places

@bb111189
Copy link
Contributor

Thanks alot . Do you mind if you create the PR to development instead.

@vinhyenvodoi98
Copy link
Author

@bb111189 ok

@bb111189
Copy link
Contributor

Thank you. We will be deploying it in a few tdays time to our production server.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants