Update for PR 4248 #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix parallellisation typo
…ocks is now a string value
improve error reporting for failing shell commands (and EasyBuild crashes)
…r_ZKoiyqjEvr minor help fix
use 5.0.x branch for easyblocks + easyconfigs in CI workflows (for now)
take into account that `VERBOSE_VERSION` imported from `easybuild.easyblocks` is now a string value
Co-authored-by: Kenneth Hoste <kenneth.hoste@ugent.be>
…output It isn't useful to report duplicate errors multiple times. And e.g. configure may report a wrong option at the start and end. Hence deduplicate it. Also change the logged warning/error to include a newline & tab in front of each element which makes it nicer to read. E.g.: > build failed (first 300 chars): Found 1 error(s) in command output: > configure: WARNING: unrecognized options: --with-foo, --with-bar (took 2 mins 39 secs)
enable RPATH linking by default
add support for running shell commands asynchronously with `run_shell_cmd`
cuda_int_comma_sep: 70,75 80 cuda_int_semicolon_sep: 70;75;80 cuda_int_space_sep: 70 75 80
allow only alphanumeric characters in the output filename
…nstructions Enhance download instructions
add cuda compute capability integer format templates
…et timestamps with touch
…th reproducible tar commands
|
I left some minor comments on 8d9e14e but other than that, without having actually run the code, it looks good to me. |
|
@Rovanion I replied to your comments. If you are happy with the changes please merge it and we can continue in the PR for easybuild. |
|
If you are OK with a merge commit I can merge it in, though the history will probably become quite ugly. A rebase of mine and your commits ontop of whatever branch you want to merge it to is more effort of course, but will result in a cleaner history. |
|
Merge commits are allowed in EasyBuild, no problem. We use them all the time. |
Rovanion
pushed a commit
that referenced
this pull request
Mar 1, 2024
clean up passing of data produced by prepare_main into main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated your PR easybuilders#4248 with the following changes to the reproducible archives:
.git.dirtouchGZIPenvironment variable by piping intogzipThis PR looks messy because I'm also syncing to current state of
5.0.xbranch.The meaningful commit is 8d9e14e