From 88e15734625c665277ddb528ef686a3a72f12840 Mon Sep 17 00:00:00 2001 From: Owen Dwyer Date: Thu, 12 Mar 2020 16:27:24 +0700 Subject: [PATCH 1/7] Update and rename 0000-template.md to text/0000-redeploy-website.md --- 0000-template.md => text/0000-redeploy-website.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename 0000-template.md => text/0000-redeploy-website.md (97%) diff --git a/0000-template.md b/text/0000-redeploy-website.md similarity index 97% rename from 0000-template.md rename to text/0000-redeploy-website.md index 983492e..8ce0717 100644 --- a/0000-template.md +++ b/text/0000-redeploy-website.md @@ -1,4 +1,4 @@ -- Start Date: (fill me in with today's date, YYYY-MM-DD) +- Start Date: (fill me in with today's date, 2020-03-12) - RFC PR: (after opening the RFC PR, update this with a link to it and update the file name) - Relevant Project: (e.g. EaselJS, SoundJS, PreloadJS, TweenJS, ...) From 80511bbc25bae7f360d2e03c84a663250cff1f8b Mon Sep 17 00:00:00 2001 From: Owen Dwyer Date: Thu, 12 Mar 2020 16:29:08 +0700 Subject: [PATCH 2/7] Create 0000-template.md --- 0000-template.md | 55 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 0000-template.md diff --git a/0000-template.md b/0000-template.md new file mode 100644 index 0000000..5b2c896 --- /dev/null +++ b/0000-template.md @@ -0,0 +1,55 @@ +- Start Date: (fill me in with today's date, YYYY-MM-DD) +- RFC PR: (after opening the RFC PR, update this with a link to it and update the file name) +- Relevant Project: (e.g. EaselJS, SoundJS, PreloadJS, TweenJS, ...) + +# + +## Summary + +> One paragraph explanation of the feature. + +## Motivation + +> Why are we doing this? What use cases does it support? What is the expected +outcome? + +## Detailed design + +> This is the bulk of the RFC. + +> Explain the design in enough detail for somebody +familiar with the project to understand, and for somebody familiar with the +implementation to implement. This should get into specifics and corner-cases, +and include examples of how the feature is used. Any new terminology should be +defined here. + +## How we teach this + +> What names and terminology work best for these concepts and why? How is this +idea best presented? As a continuation of existing patterns, or as a +wholly new one? + +> Would the acceptance of this proposal mean the CreateJS guides must be +re-organized or altered? Does it change how CreateJS is taught to new users +at any level? + +> How should this feature be introduced and taught to existing users? + +## Drawbacks + +> Why should we *not* do this? Please consider the impact on teaching CreateJS, +on the integration of this feature with other existing and planned features, +on the impact of the API churn on existing apps, etc. + +> There are tradeoffs to choosing any path, please attempt to identify them here. + +## Alternatives + +> What other designs have been considered? What is the impact of not doing this? + +> This section could also include prior art, that is, how other frameworks in the same domain have solved this problem. + +## Unresolved questions + +> Optional, but suggested for first drafts. What parts of the design are still +TBD? From aea079e26b1ac899c942c8cfe2a3a663916f319a Mon Sep 17 00:00:00 2001 From: Owen Dwyer Date: Thu, 12 Mar 2020 17:06:20 +0700 Subject: [PATCH 3/7] Update 0000-redeploy-website.md --- text/0000-redeploy-website.md | 47 +++++++++++------------------------ 1 file changed, 14 insertions(+), 33 deletions(-) diff --git a/text/0000-redeploy-website.md b/text/0000-redeploy-website.md index 8ce0717..5176c65 100644 --- a/text/0000-redeploy-website.md +++ b/text/0000-redeploy-website.md @@ -1,58 +1,39 @@ - Start Date: (fill me in with today's date, 2020-03-12) - RFC PR: (after opening the RFC PR, update this with a link to it and update the file name) -- Relevant Project: (e.g. EaselJS, SoundJS, PreloadJS, TweenJS, ...) +- Relevant Project: (All CreateJS) -# +# Redeploy Website ## Summary -> One paragraph explanation of the feature. +Move the createjs.com home page so that it is hosted on Github. ## Motivation -> Why are we doing this? What use cases does it support? What is the expected -outcome? +The createjs homepage is an essential part of the project. It has information for users, tutorials, demonstrations and a link to the current build of each module and the combined build. Notably, the current and combined builds have not been updated to reflect updates to the source files. The home page needs to be maintained and updated. ## Detailed design -> This is the bulk of the RFC. +1. Create a new repository in the CreateJS space called HomePage. -> Explain the design in enough detail for somebody -familiar with the project to understand, and for somebody familiar with the -implementation to implement. This should get into specifics and corner-cases, -and include examples of how the feature is used. Any new terminology should be -defined here. -Use definitive language, rather than proposing ideas here. The content of this -RFC can be discussed and refined on GitHub. Any unanswered questions can also -be written in the final 'Unresolved questions' section. +2. Copy all the website files to that repo. -## How we teach this +3. On Github settings, add createjs.com as a custom domain that points to that repo. -> What names and terminology work best for these concepts and why? How is this -idea best presented? As a continuation of existing patterns, or as a -wholly new one? - -> Would the acceptance of this proposal mean the CreateJS guides must be -re-organized or altered? Does it change how CreateJS is taught to new users -at any level? - -> How should this feature be introduced and taught to existing users? +4. Update the DNS for createjs.com so that it is served by Github. ## Drawbacks -> Why should we *not* do this? Please consider the impact on teaching CreateJS, -on the integration of this feature with other existing and planned features, -on the impact of the API churn on existing apps, etc. - -> There are tradeoffs to choosing any path, please attempt to identify them here. +It's hard to know what GrantSkinner will think about this and whether they'd be okay with giving up the keys to the homepage. Maybe it has some IP value. ## Alternatives -> What other designs have been considered? What is the impact of not doing this? +An alternative would be for someone who works at GrantSkinner to make changes as requested. -> This section could also include prior art, that is, how other frameworks in the same domain have solved this problem. +Another option would be to make a new homepage for createjs with a new domain name. But even if that is done, it would still be a good idea to host it on Github. ## Unresolved questions -> Optional, but suggested for first drafts. What parts of the design are still -TBD? +I'm assuming that the homepage is a static site that just includes HTML, javascript, css and images. + +It would be good to check how the site was initially built. Looks like Bootstrap was used. I don't know if any other generating software was used to build the html files or whether each page was manually created. Looking at the number of pages and simplicity, I think it could be feasible to just edit it in place rather than rebuilding from any source. From b29e5fb53c06b4bb2c4d0fbb6b334b27c092dea1 Mon Sep 17 00:00:00 2001 From: Owen Dwyer Date: Thu, 12 Mar 2020 17:10:26 +0700 Subject: [PATCH 4/7] Update 0000-redeploy-website.md --- text/0000-redeploy-website.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/text/0000-redeploy-website.md b/text/0000-redeploy-website.md index 5176c65..15b1195 100644 --- a/text/0000-redeploy-website.md +++ b/text/0000-redeploy-website.md @@ -1,6 +1,6 @@ -- Start Date: (fill me in with today's date, 2020-03-12) +- Start Date: 2020-03-12 - RFC PR: (after opening the RFC PR, update this with a link to it and update the file name) -- Relevant Project: (All CreateJS) +- Relevant Project: All CreateJS # Redeploy Website @@ -26,6 +26,10 @@ The createjs homepage is an essential part of the project. It has information f It's hard to know what GrantSkinner will think about this and whether they'd be okay with giving up the keys to the homepage. Maybe it has some IP value. +## Justification + +The advantage of hosting it on Github is that changes can be made by consensus and in a transparent way. The homepage would be maintained in the same way that the source files. This would allow people to view and comment on any changes. + ## Alternatives An alternative would be for someone who works at GrantSkinner to make changes as requested. From 2edb5e1a709ed87f197416f6a4d043349ac41fd0 Mon Sep 17 00:00:00 2001 From: Owen Dwyer Date: Thu, 12 Mar 2020 17:24:41 +0700 Subject: [PATCH 5/7] Update and rename 0000-redeploy-website.md to 0003-redeploy-website.md --- text/{0000-redeploy-website.md => 0003-redeploy-website.md} | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) rename text/{0000-redeploy-website.md => 0003-redeploy-website.md} (95%) diff --git a/text/0000-redeploy-website.md b/text/0003-redeploy-website.md similarity index 95% rename from text/0000-redeploy-website.md rename to text/0003-redeploy-website.md index 15b1195..006f3d0 100644 --- a/text/0000-redeploy-website.md +++ b/text/0003-redeploy-website.md @@ -1,5 +1,5 @@ - Start Date: 2020-03-12 -- RFC PR: (after opening the RFC PR, update this with a link to it and update the file name) +- RFC PR: https://github.com/ReCreateJS/rfcs/pull/3 - Relevant Project: All CreateJS # Redeploy Website From 9f456a3aafea592dd581841ba4aec9db8bbd0c02 Mon Sep 17 00:00:00 2001 From: Owen Dwyer Date: Fri, 13 Mar 2020 15:58:12 +0700 Subject: [PATCH 6/7] Update 0000-template.md --- 0000-template.md | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/0000-template.md b/0000-template.md index 5b2c896..45a00b8 100644 --- a/0000-template.md +++ b/0000-template.md @@ -17,11 +17,7 @@ outcome? > This is the bulk of the RFC. -> Explain the design in enough detail for somebody -familiar with the project to understand, and for somebody familiar with the -implementation to implement. This should get into specifics and corner-cases, -and include examples of how the feature is used. Any new terminology should be -defined here. +> Explain the design in enough detail for somebody familiar with the project to understand, and for somebody familiar with the implementation to implement. This should get into specifics and corner-cases, and include examples of how the feature is used. Any new terminology should be defined here. Use definitive language, rather than proposing ideas here. The content of this RFC can be discussed and refined on GitHub. Any unanswered questions can also be written in the final 'Unresolved questions' section. ## How we teach this From 7cfb94cdf5b52cd9989188a6b22823b4c31d9213 Mon Sep 17 00:00:00 2001 From: Owen Dwyer Date: Fri, 13 Mar 2020 16:00:40 +0700 Subject: [PATCH 7/7] Update 0000-template.md --- 0000-template.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/0000-template.md b/0000-template.md index 45a00b8..983492e 100644 --- a/0000-template.md +++ b/0000-template.md @@ -17,7 +17,14 @@ outcome? > This is the bulk of the RFC. -> Explain the design in enough detail for somebody familiar with the project to understand, and for somebody familiar with the implementation to implement. This should get into specifics and corner-cases, and include examples of how the feature is used. Any new terminology should be defined here. Use definitive language, rather than proposing ideas here. The content of this RFC can be discussed and refined on GitHub. Any unanswered questions can also be written in the final 'Unresolved questions' section. +> Explain the design in enough detail for somebody +familiar with the project to understand, and for somebody familiar with the +implementation to implement. This should get into specifics and corner-cases, +and include examples of how the feature is used. Any new terminology should be +defined here. +Use definitive language, rather than proposing ideas here. The content of this +RFC can be discussed and refined on GitHub. Any unanswered questions can also +be written in the final 'Unresolved questions' section. ## How we teach this