Instrument LOG0-LOG4 gas function #492
Open
+50
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MishkaRogachev
force-pushed
the
instrument_log0_4_gas_func
branch
from
9170c6c to
a260a06
Compare
MishkaRogachev
commented
Jul 18, 2025
| if err != nil { | ||
| return multigas.ZeroGas(), 0, err | ||
| } | ||
|
|
||
| // TODO(NIT-3484): Update multi dimensional gas here | ||
| if gas, overflow = math.SafeAdd(gas, params.LogGas); overflow { | ||
| if overflow = multiGas.SafeIncrement(multigas.ResourceKindComputation, params.LogGas); overflow { |
There was a problem hiding this comment.
My assumption: HistoryGrowth := requestedSize * params.LogDataGas (8), others cost values are computation. Not sure about bloomHistoryGrowthCost, is it charged outside of VM?
Based on:
MishkaRogachev
force-pushed
the
instrument_log0_4_gas_func
branch
from
a260a06 to
0da73bc
Compare
MishkaRogachev
changed the base branch from
cbp-feature
to
instrument_call_gas_func
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For NIT-3481
Instrument LOG0-LOG4 opcodes with multigas calculations:
makeGasLogfuncNote: waits #486 to be merged, temporary points on
instrument_call_gas_funcbranch