From bd918e484e3cd00409f349da836cb220dbda704c Mon Sep 17 00:00:00 2001 From: David ML Brown Jr Date: Sun, 23 Oct 2022 15:30:17 -0700 Subject: [PATCH 1/2] Add Pull Request Template This adds a pull request template from the kb_uploadmethods app referenced [here](https://github.com/kbaseapps/kb_uploadmethods/blob/master/.github/pull_request_template.md). Signed-off-by: David ML Brown Jr --- .github/pull_request_template.md | 32 ++++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..423436c0 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,32 @@ +# Description of PR purpose/changes + +- Please include a summary of the change and which issue is fixed. +- Please also include relevant motivation and context. +- List any dependencies that are required for this change. + +# Jira Ticket / Issue + +e.g. + +- [ ] Added the Jira Ticket to the title of the PR e.g. (DATAUP-69 Adds a PR template) + +# Testing Instructions + +- Details for how to test the PR: +- [ ] Tests pass in Travis-CI, GitHub Actions and locally + +# Dev Checklist: + +- [ ] My code follows the guidelines at +- [ ] I have performed a self-review of my own code +- [ ] I have commented my code, particularly in hard-to-understand areas +- [ ] I have made corresponding changes to the documentation, including updating the README with app information changes +- [ ] My changes generate no new warnings +- [ ] I have added tests that prove my fix is effective or that my feature works +- [ ] New and existing tests pass locally with my changes +- [ ] Any dependent changes have been merged and published in downstream modules + +# Updating Version and Release Notes (if applicable) + +- [ ] [Version has been bumped](https://semver.org/) in `kbase.yml` +- [ ] [Release notes](/RELEASE_NOTES.md) have been updated for each release (and during the merge of feature branches) From d7543f153f35fcd382b7101c5b9482a8545ea9b6 Mon Sep 17 00:00:00 2001 From: David ML Brown Jr Date: Thu, 15 Dec 2022 11:46:47 -0800 Subject: [PATCH 2/2] Run pre-commit fix the template Signed-off-by: David ML Brown Jr --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 423436c0..60c7c6d5 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -12,7 +12,7 @@ e.g. # Testing Instructions -- Details for how to test the PR: +- Details for how to test the PR: - [ ] Tests pass in Travis-CI, GitHub Actions and locally # Dev Checklist: