Adjust click event threshold for XR Device ray interaction from 1px to 5px #100

Copilot · 2025-07-18T10:59:45Z

This PR increases the click event distance threshold from 1 pixel to 5 pixels to improve click detection reliability for XR device ray interactions.

Problem

In the current implementation, click events are only triggered when the distance between mousedown and mouseup hit points is less than 1 pixel. While this works well for traditional mouse interactions, XR device ray interactions often experience slight jitter that makes it difficult to trigger click events consistently.

Solution

The change increases the threshold from client_cssom::pixelToMeter(1) to client_cssom::pixelToMeter(5) in the DocumentEventDispatcher class:

// Before
static inline float click_distance_threshold_ = client_cssom::pixelToMeter(1);

// After  
static inline float click_distance_threshold_ = client_cssom::pixelToMeter(5);

Technical Details

Old threshold: 1px ≈ 0.276mm in world space
New threshold: 5px ≈ 1.38mm in world space
Impact: 5x increase provides better tolerance for XR ray jitter while maintaining click vs drag distinction
Scope: Single line change with no breaking changes to existing APIs

The threshold is used in the click detection logic to determine if a selectStart and selectEnd event pair should generate a click event based on spatial proximity of the hit points.

Fixes #86.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

registry.npmmirror.com
- Triggering command: npm install (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to my firewall allow list

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…raction Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>

yorkie

How about making this configurable?

…nvironment variable Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>

Copilot · 2025-07-18T12:12:38Z

How about making this configurable?

Made the click distance threshold configurable via Android property jsar.xr.click.distance.threshold and environment variable JSAR_XR_CLICK_DISTANCE_THRESHOLD. The implementation follows existing patterns in the codebase with proper validation and maintains the 5px default. See commit fafd4fa.

yorkie

See https://www.w3.org/TR/uievents/.

This threshold is not related to the XR-specific concepts, it's defined at Web UI Events spec, please rename the related configurations in this PR.

yorkie · 2025-07-18T16:15:40Z

src/client/dom/document_event_dispatcher.hpp

@@ -48,6 +48,7 @@ namespace dom
    glm::vec3 current_scroll_end_point_;
    bool is_scroll_in_progress_ = false;

-    static inline float click_distance_threshold_ = client_cssom::pixelToMeter(1);
+    static float getClickDistanceThreshold();


Static members should use uppercase for first char.

Fixed static member naming to use uppercase first character: click_distance_threshold_ → Click_distance_threshold_. See commit 0308c1b.

…aming and fix static member naming convention Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>

Copilot · 2025-07-18T16:22:48Z

See https://www.w3.org/TR/uievents/.

This threshold is not related to the XR-specific concepts, it's defined at Web UI Events spec, please rename the related configurations in this PR.

Renamed the configuration to follow Web UI Events spec naming. Changed Android property from jsar.xr.click.distance.threshold to jsar.click.distance.threshold and environment variable from JSAR_XR_CLICK_DISTANCE_THRESHOLD to JSAR_CLICK_DISTANCE_THRESHOLD. Updated documentation accordingly. See commit 0308c1b.

yorkie · 2025-07-18T16:27:59Z

src/client/dom/document_event_dispatcher.hpp

@@ -48,6 +48,7 @@ namespace dom
    glm::vec3 current_scroll_end_point_;
    bool is_scroll_in_progress_ = false;

-    static inline float click_distance_threshold_ = client_cssom::pixelToMeter(1);
+    static float getClickDistanceThreshold();


Suggested change

static float getClickDistanceThreshold();

static float GetClickDistanceThreshold();

Updated function name to GetClickDistanceThreshold with uppercase first character. See commit 959a984.

yorkie · 2025-07-18T16:30:48Z

docs/manual/references/runtime-configuration.mdx

+adb shell setprop jsar.click.distance.threshold 5
+```
+
+This controls the maximum distance (in pixels) between `mousedown` and `mouseup` hit points for triggering click events. The default value is 5 pixels, which provides good tolerance for ray jitter while maintaining distinction between click and drag gestures.


Please explain the distance threshold at first, and add link to the related Web spec, and then provide the help to how to config it.

Restructured documentation to first explain the distance threshold concept with reference to Web UI Events specification, then provide configuration instructions. See commit 959a984.

yorkie · 2025-07-18T16:31:44Z

docs/manual/references/runtime-configuration.mdx

+To configure the click distance threshold for device ray interactions:
+
+```sh
+adb shell setprop jsar.click.distance.threshold 5


How about this?

Suggested change

adb shell setprop jsar.click.distance.threshold 5

adb shell setprop jsar.events.click_distance_threshold 5

Changed Android property name to jsar.events.click_distance_threshold using events namespace and underscore separator. See commit 959a984.

…erty naming, and documentation structure Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>

Initial plan

a693986

Copilot AI assigned Copilot and yorkie Jul 18, 2025

Copilot started work on behalf of yorkie July 18, 2025 10:59 View session

Increase click event threshold from 1px to 5px for XR Device ray inte…

c721db1

…raction Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] adjust click event threshold for XR Device ray interaction~~ Adjust click event threshold for XR Device ray interaction from 1px to 5px Jul 18, 2025

Copilot AI requested a review from yorkie July 18, 2025 11:10

Copilot finished work on behalf of yorkie July 18, 2025 11:10

yorkie requested changes Jul 18, 2025

View reviewed changes

Copilot started work on behalf of yorkie July 18, 2025 12:04 View session

Make click distance threshold configurable via Android property and e…

fafd4fa

…nvironment variable Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>

Copilot AI requested a review from yorkie July 18, 2025 12:14

Copilot finished work on behalf of yorkie July 18, 2025 12:14

yorkie requested changes Jul 18, 2025

View reviewed changes

Copilot started work on behalf of yorkie July 18, 2025 16:15 View session

Rename click distance threshold configuration to remove XR-specific n…

0308c1b

…aming and fix static member naming convention Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>

Copilot AI requested a review from yorkie July 18, 2025 16:23

Copilot finished work on behalf of yorkie July 18, 2025 16:23

yorkie requested changes Jul 18, 2025

View reviewed changes

Copilot started work on behalf of yorkie July 18, 2025 16:31 View session

Address code review feedback: update function naming convention, prop…

959a984

…erty naming, and documentation structure Co-authored-by: yorkie <1935767+yorkie@users.noreply.github.com>

Copilot AI requested a review from yorkie July 18, 2025 16:36

Copilot finished work on behalf of yorkie July 18, 2025 16:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Adjust click event threshold for XR Device ray interaction from 1px to 5px #100

Adjust click event threshold for XR Device ray interaction from 1px to 5px #100

Copilot AI commented Jul 18, 2025 •

edited

Loading

Uh oh!

yorkie left a comment

Uh oh!

Copilot AI commented Jul 18, 2025

Uh oh!

yorkie left a comment

Uh oh!

yorkie Jul 18, 2025

Uh oh!

Copilot AI Jul 18, 2025

Uh oh!

Copilot AI commented Jul 18, 2025

Uh oh!

yorkie Jul 18, 2025

Uh oh!

Copilot AI Jul 18, 2025

Uh oh!

yorkie Jul 18, 2025

Uh oh!

Copilot AI Jul 18, 2025

Uh oh!

yorkie Jul 18, 2025

Uh oh!

Copilot AI Jul 18, 2025

Uh oh!

Uh oh!

	static float getClickDistanceThreshold();
	static float GetClickDistanceThreshold();

	adb shell setprop jsar.click.distance.threshold 5
	adb shell setprop jsar.events.click_distance_threshold 5

Adjust click event threshold for XR Device ray interaction from 1px to 5px #100

Are you sure you want to change the base?

Adjust click event threshold for XR Device ray interaction from 1px to 5px #100

Conversation

Copilot AI commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Solution

Technical Details

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

yorkie left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jul 18, 2025

Uh oh!

yorkie left a comment

Choose a reason for hiding this comment

Uh oh!

yorkie Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Jul 18, 2025

Uh oh!

yorkie Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

yorkie Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

yorkie Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jul 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Jul 18, 2025 •

edited

Loading