Skip to content

Commit 03170e3

Browse files
author
Gregory Mitchell
authored
Fix Coordinate#toString, Update Coordinate Tests
1 parent 4b7593f commit 03170e3

File tree

4 files changed

+20
-13
lines changed

4 files changed

+20
-13
lines changed

src/main/java/me/gamercoder215/calcgames/levelz/coord/Coordinate2D.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,11 +125,10 @@ public int hashCode() {
125125
@Override
126126
public String toString() {
127127
int xInt = (int) x, yInt = (int) y;
128+
String xs = x == xInt ? String.valueOf(xInt) : String.valueOf(x);
129+
String ys = y == yInt ? String.valueOf(yInt) : String.valueOf(y);
128130

129-
if (x == xInt && y == yInt)
130-
return "[" + xInt + ", " + yInt + "]";
131-
else
132-
return "[" + x + ", " + y + "]";
131+
return "[" + xs + ", " + ys + "]";
133132
}
134133

135134
/**

src/main/java/me/gamercoder215/calcgames/levelz/coord/Coordinate3D.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -131,11 +131,11 @@ public int hashCode() {
131131
@Override
132132
public String toString() {
133133
int xInt = (int) x, yInt = (int) y, zInt = (int) z;
134+
String xs = x == xInt ? String.valueOf(xInt) : String.valueOf(x);
135+
String ys = y == yInt ? String.valueOf(yInt) : String.valueOf(y);
136+
String zs = z == zInt ? String.valueOf(zInt) : String.valueOf(z);
134137

135-
if (x == xInt && y == yInt && z == zInt)
136-
return "[" + xInt + ", " + yInt + ", " + zInt + "]";
137-
else
138-
return "[" + x + ", " + y + ", " + z + "]";
138+
return "[" + xs + ", " + ys + ", " + zs + "]";
139139
}
140140

141141
/**

src/test/java/me/gamercoder215/calcgames/levelz/coord/TestCoordinate2D.java

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,20 @@ public void testFromString() {
2626
Assertions.assertEquals(new Coordinate2D(0.5, 1), Coordinate2D.fromString("[0.5, 1.0]"));
2727

2828
Coordinate2D a = new Coordinate2D(0, 0);
29-
Assertions.assertEquals(a.toString(), "[0.0, 0.0]");
29+
Assertions.assertEquals(a.toString(), "[0, 0]");
3030
Assertions.assertEquals(a, Coordinate2D.fromString(a.toString()));
3131

3232
Coordinate2D b = new Coordinate2D(3, 4);
33-
Assertions.assertEquals(b.toString(), "[3.0, 4.0]");
33+
Assertions.assertEquals(b.toString(), "[3, 4]");
3434
Assertions.assertEquals(b, Coordinate2D.fromString(b.toString()));
3535

3636
Coordinate2D c = new Coordinate2D(2.5, -1.25);
3737
Assertions.assertEquals(c.toString(), "[2.5, -1.25]");
3838
Assertions.assertEquals(c, Coordinate2D.fromString(c.toString()));
39+
40+
Coordinate2D d = new Coordinate2D(-7, 9.5);
41+
Assertions.assertEquals(d.toString(), "[-7, 9.5]");
42+
Assertions.assertEquals(d, Coordinate2D.fromString(d.toString()));
3943
}
4044

4145
}

src/test/java/me/gamercoder215/calcgames/levelz/coord/TestCoordinate3D.java

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,16 +26,20 @@ public void testFromString() {
2626
Assertions.assertEquals(new Coordinate3D(0.5, -1, -0.5), Coordinate3D.fromString("[0.5, -1.0, -0.5]"));
2727

2828
Coordinate3D a = new Coordinate3D(0, 0, 0);
29-
Assertions.assertEquals(a.toString(), "[0.0, 0.0, 0.0]");
29+
Assertions.assertEquals(a.toString(), "[0, 0, 0]");
3030
Assertions.assertEquals(a, Coordinate3D.fromString(a.toString()));
3131

32-
Coordinate3D b = new Coordinate3D(3, 4, -2);
33-
Assertions.assertEquals(b.toString(), "[3.0, 4.0, -2.0]");
32+
Coordinate3D b = new Coordinate3D(3, 4, -2.5);
33+
Assertions.assertEquals(b.toString(), "[3, 4, -2.5]");
3434
Assertions.assertEquals(b, Coordinate3D.fromString(b.toString()));
3535

3636
Coordinate3D c = new Coordinate3D(2.5, -1.25, 12.5);
3737
Assertions.assertEquals(c.toString(), "[2.5, -1.25, 12.5]");
3838
Assertions.assertEquals(c, Coordinate3D.fromString(c.toString()));
39+
40+
Coordinate3D d = new Coordinate3D(-11, -45.75, 88);
41+
Assertions.assertEquals(d.toString(), "[-11, -45.75, 88]");
42+
Assertions.assertEquals(d, Coordinate3D.fromString(d.toString()));
3943
}
4044

4145
}

0 commit comments

Comments
 (0)