Issue 50356: Remove unused UI that contains usages of javascript: URLs (#69)

Author: labkey-susanh

src/org/labkey/workflow/WorkflowController.java

@@ -173,29 +173,6 @@ public void addNavTrail(NavTree root)
     }
 
 
-    @RequiresPermission(ReadPermission.class)
-    public class StartProcessFormAction extends SimpleViewAction<StartWorkflowProcessForm>
-    {
-        @Override
-        public ModelAndView getView(StartWorkflowProcessForm form, BindException errors) throws Exception
-        {
-            WorkflowProcess bean = new WorkflowProcessImpl(form.getProcessDefinitionKey(), form.getWorkflowModelModule());
-            JspView jsp = new JspView<>("/org/labkey/workflow/view/workflowProcessStart.jsp", bean, errors);
-            return jsp;
-        }
-
-        @Override
-        public void validate(StartWorkflowProcessForm form, BindException errors)
-        {
-            form.validate(getUser(), getContainer(), errors);
-        }
-
-        @Override
-        public void addNavTrail(NavTree root)
-        {
-        }
-    }
-
     /**
      * Shows a list of tasks that are associated with a particular workflow.
      */
@@ -326,7 +303,7 @@ private String validateProcessDefinitionKey(WorkflowRequestForm form)
      * Shows the data about a task if the user has permissions to see this task
      */
     @RequiresPermission(ReadPermission.class)
-    public class TaskAction extends SimpleViewAction<WorkflowTaskForm>
+    public static class TaskAction extends SimpleViewAction<WorkflowTaskForm>
     {
         private String _navLabel = "Task details";
         private WorkflowTask _task;
@@ -1252,4 +1229,4 @@ public void setModuleName(String moduleName)
         }
     }
 
-}
+}

src/org/labkey/workflow/view/WorkflowViewBase.java

@@ -27,7 +27,6 @@
 import org.labkey.api.util.PageFlowUtil;
 import org.labkey.api.util.StringUtilsLabKey;
 import org.labkey.api.view.ActionURL;
-import org.labkey.api.workflow.TaskFormField;
 import org.labkey.api.workflow.WorkflowProcess;
 import org.labkey.workflow.WorkflowController;
 
@@ -103,51 +102,6 @@ private Object getParameterValue(String key, Object value)
         return value;
     }
 
-    public String actionForm(String name, String formName, String formAction, Map<String, TaskFormField> fields, @Nullable Map<String, String> hiddenFields)
-    {
-        StringBuilder builder = new StringBuilder();
-        builder.append("<strong>").append(h(name)).append("</strong>");
-        builder.append("<br><br>\n");
-        builder.append("<form name=\"").append(h(formName)).append("\" action=\"").append(h(formAction)).append("\">\n");
-        for (Map.Entry<String, TaskFormField> field : fields.entrySet())
-        {
-            // TODO add a type that is text area that has "information" for the rows and columns
-            // TODO handle other input field types as well: date, long, boolean
-            if (field.getValue().getType().equals("string"))
-            {
-                builder.append(h(field.getValue().getName()));
-                builder.append("\n<br>\n");
-                builder.append("<textarea title=\"").append(field.getValue().getName()).append("\" name=\"").append(field.getValue().getId()).append("\" rows=\"10\" cols=\"100\"></textarea>\n<br>\n");
-            }
-            else if (field.getValue().getType().equals("enum"))
-            {
-                Map<String, String> choices = (Map<String, String>) field.getValue().getInformation("values");
-                if (choices != null && !choices.isEmpty())
-                {
-                    builder.append(h(field.getValue().getName()));
-                    builder.append("<select title=\"").append(h(field.getValue().getName())).append("\" name=\"").append(h(field.getValue().getId())).append("\">");
-                    for (Map.Entry<String, String> choice : ((Map<String, String>) field.getValue().getInformation("values")).entrySet())
-                    {
-                        builder.append("<option value=\"").append(h(choice.getKey())).append("\">").append(h(choice.getValue())).append("</option>");
-                    }
-                    builder.append("</select>\n");
-                    builder.append("<br>\n");
-                }
-            }
-        }
-        if (hiddenFields != null)
-        {
-            for (Map.Entry<String, String> hiddenField : hiddenFields.entrySet())
-            {
-                builder.append("<input type=\"hidden\" name=\"").append(h(hiddenField.getKey())).append("\" value=\"").append(h(hiddenField.getValue())).append("\" >\n");
-            }
-        }
-        builder.append("<br><br>\n");
-        builder.append(PageFlowUtil.button("Submit").submit(true));
-        builder.append("\n</form>\n");
-        return builder.toString();
-    }
-
 
     @Nullable
     public Map<String, Object> getDisplayVariables(Container container, Map<String, Object> variables)

src/org/labkey/workflow/view/workflowProcessStart.jsp

@@ -15,7 +15,6 @@
  * limitations under the License.
  */
 %>
-<%@ page import="org.apache.commons.lang3.StringUtils" %>
 <%@ page import="org.labkey.api.util.DateUtil" %>
 <%@ page import="org.labkey.api.view.HttpView" %>
 <%@ page import="org.labkey.api.view.template.ClientDependencies" %>
@@ -146,12 +145,9 @@
 <%
                 }
             }
-            else
-            {
+            else {
 %>
-<%= unsafe(actionForm(bean.getName(), bean.getTaskDefinitionKey(),
-        "javascript:completeWorkflowTask(" + q(bean.getId()) + "," + qh(bean.getTaskDefinitionKey()) + ", ['" + StringUtils.join(fields.keySet(), "', '") + "']," + q(bean.getProcessInstanceId()) + ", " + qh(bean.getProcessDefinitionKey(getContainer())) + ")", fields, null)) %>
-<br>
+                <div>Unsupported in UI</div>
 <%
             }
         }