Skip to content

Commit 9ad646e

Browse files
Issue 53067: Update gradle plugins version for better npm task behavior (#1118)
1 parent f5b112c commit 9ad646e

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

gradle.properties

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ org.gradle.parallel=true
1212
# (this could be memory-intensive)
1313
org.gradle.workers.max=3
1414
# Default to using 2GB of memory for the JVM.
15-
org.gradle.jvmargs=-Xmx2048m -XX:+UseParallelGC
15+
org.gradle.jvmargs=-Xmx2048m -XX:+UseParallelGC -Dfile.encoding=UTF-8
1616
# Uncomment to restrict the number of concurrent npm build tasks. Useful for systems with limited resources.
1717
#npmRunLimit=2
1818

@@ -59,7 +59,7 @@ windowsProteomicsBinariesVersion=1.0
5959
# The current version numbers for the gradle plugins.
6060
artifactoryPluginVersion=5.2.5
6161
gradleNodePluginVersion=7.1.0
62-
gradlePluginsVersion=6.2.0
62+
gradlePluginsVersion=6.3.0
6363
owaspDependencyCheckPluginVersion=12.1.3
6464
versioningPluginVersion=1.1.2
6565

gradle/settings/all.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ buildscript {
2424
{
2525
mavenLocal()
2626
maven {
27-
url "${artifactory_contextUrl}/plugins-snapshot-local"
27+
url = "${artifactory_contextUrl}/plugins-snapshot-local"
2828
mavenContent {
2929
snapshotsOnly()
3030
}

server/build.gradle

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,7 @@ project.tasks.register("reportVersionToTeamCity", DefaultTask) {
191191
println "##teamcity[setParameter name='labkey.version' value='${labkeyVersion}']"
192192
})
193193
}
194+
194195
if (project.hasProperty("teamcity"))
195196
{
196197
project.tasks.named('stageApp').configure { dependsOn(project.tasks.named('reportVersionToTeamCity')) }
@@ -210,14 +211,11 @@ else
210211
task.description = "Copy dependencies required for JSP dynamic compiling"
211212
task.into project.rootProject.layout.buildDirectory.dir("jspRecompiling")
212213
task.from project.configurations.recompilingJsp
213-
task.mustRunAfter(cleanJspRecompileSetup)
214+
task.dependsOn(cleanJspRecompileSetup)
214215
if (project.hasProperty('apacheTomcatVersion'))
215216
task.inputs.property 'apacheTomcatVersion', project.property('apacheTomcatVersion')
216217
else
217218
task.outputs.cacheIf { false } // Just don't cache if we can't be sure of the Jasper version
218-
task.doFirst {
219-
project.delete project.rootProject.layout.buildDirectory.dir("jspRecompiling")
220-
}
221219
}
222220

223221
project.tasks.named('deployApp').configure {

0 commit comments

Comments
 (0)