Skip to content

Commit c095478

Browse files
authored
Fix integration tests & insert rows example (#49)
1 parent f5bcd73 commit c095478

File tree

3 files changed

+11
-11
lines changed

3 files changed

+11
-11
lines changed

samples/query_examples.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@
211211
all_rows = api.query.select_rows(schema, table)
212212
print("Insert Rows: Initials row count [ " + str(all_rows["rowCount"]) + " ]")
213213

214-
insert_result = api.query.select_rows(schema, table, [test_row])
214+
insert_result = api.query.insert_rows(schema, table, [test_row])
215215
print("Insert Rows: New rowId [ " + str(insert_result["rows"][0]["Key"]) + " ]")
216216

217217
all_rows = api.query.select_rows(schema, table)

test/integration/test_query.py

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -62,14 +62,15 @@ def dataset(api: APIWrapper, study):
6262

6363
@pytest.fixture(scope="function")
6464
def qc_states(api: APIWrapper, study):
65-
insert_result = api.query.insert_rows("core", "qcstate", TEST_QC_STATES)
65+
print(api.security.who_am_i())
66+
insert_result = api.query.insert_rows("core", "datastates", TEST_QC_STATES)
6667
yield insert_result
6768
# clean up
6869
cleanup_qc_states = [
6970
{"rowId": insert_result["rows"][0]["rowid"]},
7071
{"rowId": insert_result["rows"][1]["rowid"]},
7172
]
72-
api.query.delete_rows("core", "qcstate", cleanup_qc_states)
73+
api.query.delete_rows("core", "datastates", cleanup_qc_states)
7374

7475

7576
def test_api_select_rows(api: APIWrapper):
@@ -105,15 +106,15 @@ def test_update_qc_state_definition(api: APIWrapper, qc_states, study):
105106
edit_rowid = qc_states["rows"][0]["rowid"]
106107
assert qc_states["rows"][0]["description"] != new_description
107108
to_edit_row = [{"rowid": edit_rowid, "description": new_description}]
108-
update_response = api.query.update_rows("core", "qcstate", to_edit_row)
109+
update_response = api.query.update_rows("core", "datastates", to_edit_row)
109110
assert update_response["rowsAffected"] == 1
110111
assert update_response["rows"][0]["description"] == new_description
111112

112113

113114
def test_insert_duplicate_labeled_qc_state_produces_error(api: APIWrapper, qc_states, study):
114115
with pytest.raises(ServerContextError) as e:
115116
dupe_qc_state = [{"label": "needs verification", "publicData": "false"}]
116-
api.query.insert_rows("core", "qcstate", dupe_qc_state)
117+
api.query.insert_rows("core", "datastates", dupe_qc_state)
117118

118119
assert "500: ERROR: duplicate key value violates unique constraint" in e.value.message
119120

@@ -135,11 +136,11 @@ def test_cannot_delete_qc_state_in_use(api: APIWrapper, qc_states, study, datase
135136

136137
with pytest.raises(ServerContextError) as e:
137138
qc_state_to_delete = [{"rowid": qc_state_rowid}]
138-
api.query.delete_rows("core", "qcstate", qc_state_to_delete)
139+
api.query.delete_rows("core", "datastates", qc_state_to_delete)
139140

140141
assert (
141142
e.value.message
142-
== "\"400: QC state 'needs verification' cannot be deleted as it is currently in use.\""
143+
== "\"400: State 'needs verification' cannot be deleted as it is currently in use.\""
143144
)
144145
# now clean up/stop using it
145146
dataset_row_to_remove = [{"lsid": inserted_lsid}]

test/integration/test_security.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
from labkey.security import who_am_i
21
import pytest
32
from labkey.api_wrapper import APIWrapper
43

@@ -24,21 +23,21 @@ def test_user(api: APIWrapper, project):
2423
def test_impersonation(api: APIWrapper, test_user):
2524
# test impersonation via email
2625
api.security.impersonate_user(email=TEST_EMAIL)
27-
who = who_am_i(api.server_context)
26+
who = api.security.who_am_i()
2827
assert who.display_name == test_user["display_name"]
2928
assert who.email == test_user["email"]
3029
assert who.id == test_user["id"]
3130

3231
# test stop impersonating
3332
api.security.stop_impersonating()
34-
who = who_am_i(api.server_context)
33+
who = api.security.who_am_i()
3534
assert who.display_name != test_user["display_name"]
3635
assert who.email != test_user["email"]
3736
assert who.id != test_user["id"]
3837

3938
# test impersonation via user id
4039
api.security.impersonate_user(user_id=test_user["id"])
41-
who = who_am_i(api.server_context)
40+
who = api.security.who_am_i()
4241
assert who.display_name == test_user["display_name"]
4342
assert who.email == test_user["email"]
4443
assert who.id == test_user["id"]

0 commit comments

Comments
 (0)