Added doctrine mappings and minor improvements inside phone

Author: benatespina

src/LIN3S/SharedKernel/Domain/Model/Phone.php

@@ -20,37 +20,33 @@ class Phone
 
     public function __construct($phone)
     {
-        $this->phone = $phone ? $this->cleanPhone($phone) : '';
+        $this->phone = $this->setPhone($phone);
+    }
+
+    public function phone()
+    {
+        return $this->phone;
     }
 
     public function equals(Phone $phone)
     {
-        return strtolower((string)$this) === strtolower((string)$phone);
+        return $this->phone === $phone->phone();
     }
 
     public function __toString()
     {
         return (string)$this->phone;
     }
 
-    private function cleanPhone($phone)
+    private function setPhone($phone)
     {
-        $absolute = $phone[0] === '+';
+        $phone = str_replace('+34', '', $phone);
         $numbers = preg_replace('/\D/', '', $phone);
 
         if (!$numbers) {
             throw new PhoneFormatInvalidException();
         }
 
-        // special logic for russian local phone notation
-        if ($numbers[0] === '8' && !$absolute && strlen($numbers) == 11) {
-            $numbers[0] = '7';
-        }
-
-        if ($numbers[0] !== '7' || strlen($numbers) != 11) {
-            throw new PhoneFormatInvalidException();
-        }
-
         return $numbers;
     }
 }

src/LIN3S/SharedKernel/Infrastructure/Persistence/Doctrine/ORM/Mapping/Email.orm.xml

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<doctrine-mapping xmlns="http://doctrine-project.org/schemas/orm/doctrine-mapping"
+                  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+                  xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping
+                          http://raw.github.com/doctrine/doctrine2/master/doctrine-mapping.xsd">
+
+    <embeddable name="LIN3S\SharedKernel\Domain\Model\Email">
+        <field name="email" type="string" length="255" nullable="false"/>
+    </embeddable>
+</doctrine-mapping>

src/LIN3S/SharedKernel/Infrastructure/Persistence/Doctrine/ORM/Mapping/Phone.orm.xml

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<doctrine-mapping xmlns="http://doctrine-project.org/schemas/orm/doctrine-mapping"
+                  xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+                  xsi:schemaLocation="http://doctrine-project.org/schemas/orm/doctrine-mapping
+                          http://raw.github.com/doctrine/doctrine2/master/doctrine-mapping.xsd">
+
+    <embeddable name="LIN3S\SharedKernel\Domain\Model\Phone">
+        <field name="phone" type="string" length="20" nullable="false"/>
+    </embeddable>
+</doctrine-mapping>