Skip to content

ci: Dynamically assign testbed name for benchmarks #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mhovd
Copy link
Collaborator

@mhovd mhovd commented Jul 19, 2025

Ensures that benchmarks are accurately compared

@Copilot Copilot AI review requested due to automatic review settings July 19, 2025 09:49
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub Actions workflow files to dynamically assign testbed names for benchmarks using the runner name instead of a hardcoded "orion" value. This change ensures that benchmarks are accurately compared by using the actual runner environment as the testbed identifier.

Key changes:

  • Replace hardcoded testbed name with dynamic runner name reference
  • Minor formatting improvement to branch specification syntax

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/pr_benchmarks.yml Updates testbed parameter to use dynamic runner name
.github/workflows/base_benchmarks.yml Updates testbed parameter to use dynamic runner name and improves branch syntax

Copy link
Contributor

🐰 Bencher Report

Branchci-benchmark
Testbedpmcore-runner

⚠️ WARNING: No Threshold found!

Without a Threshold, no Alerts will ever be generated.

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds flag.

Click to view all benchmark results
BenchmarkLatencyseconds (s)
bimodal_ke_fit📈 view plot
⚠️ NO THRESHOLD
10.19 s
🐰 View full continuous benchmarking report in Bencher

@mhovd
Copy link
Collaborator Author

mhovd commented Jul 19, 2025

We already have this change in pharmsol, and need it in PMcore as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant