Fix org.jabref.logic.openoffice.oocsltext.CSLFormatUtilsTest

[koppor]

I merged #13411 too fast. Tests fail.

Task: Adapt the tests so that the expectations conform with the input. A nice exercise how to use "Show differences" in IntelliJ. See https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace/intellij-12-build.html#final-build-system-checks for an initial howto how to run tests using IntelliJ.

 org.jabref.logic.openoffice.oocsltext.CSLFormatUtilsTest

  updateSingleNumericBibliography(String, CitationStyle)

    Test [1] [3] B. Smith, B. Jones, and J. Williams, “Title of the test entry,” <i>BibTeX Journal</i>, vol. 34, no. 3, pp. 45–67, Jul. 2016, doi: 10.1001/bla.blubb.<p></p>, IEEE FAILED

    org.opentest4j.AssertionFailedError: expected: <[3] B. Smith, B. Jones, and J. Williams, “Title of the test entry,” <i>BibTeX Journal</i>, vol. 34, no. 3, pp. 45–67, Jul. 2016, doi: 10.1001/bla.blubb.<p></p>> but was: <[3] B. Smith, B. Jones, and J. Williams, “Title of the test entry,” <i>BibTeX Journal</i>, vol. 34, no. 3, pp. 45–67, July 2016, doi: 10.1001/bla.blubb.<p></p>>


  ooHTMLTransformFromRawBibliography(String, CitationStyle)

    Test [2] [1] B. Smith, B. Jones, and J. Williams, “Title of the test entry,” <i>BibTeX Journal</i>, vol. 34, no. 3, pp. 45–67, Jul. 2016, doi: 10.1001/bla.blubb.<p></p>, IEEE FAILED

    org.opentest4j.AssertionFailedError: expected: <[1] B. Smith, B. Jones, and J. Williams, “Title of the test entry,” <i>BibTeX Journal</i>, vol. 34, no. 3, pp. 45–67, Jul. 2016, doi: 10.1001/bla.blubb.<p></p>> but was: <[1] B. Smith, B. Jones, and J. Williams, “Title of the test entry,” <i>BibTeX Journal</i>, vol. 34, no. 3, pp. 45–67, July 2016, doi: 10.1001/bla.blubb.<p></p>>

    Test [5] 1. Smith B, Jones B, Williams J. Title of the test entry. Taylor P, editor. BibTeX Journal [Internet]. 2016 Jul;34(3):45–67. Available from: https://github.com/JabRef<p></p>, Vancouver FAILED

    org.opentest4j.AssertionFailedError: expected: <1. Smith B, Jones B, Williams J. Title of the test entry. Taylor P, editor. BibTeX Journal [Internet]. 2016 Jul;34(3):45–67. Available from: https://github.com/JabRef<p></p>> but was: <1. Smith B, Jones B, Williams J. Title of the test entry. Taylor P, editor. BibTeX Journal [Internet]. 2016 July;34(3):45–67. Available from: https://github.com/JabRef<p></p>>

[Munhangyeol]

/assign-me

[github-actions]

👋 Hey @Munhangyeol, thank you for your interest in this issue! 🎉

We're excited to have you on board. Start by exploring our Contributing guidelines, and don't forget to check out our workspace setup guidelines to get started smoothly.

For questions on JabRef functionality and the code base, you can consult the JabRef Guru or ask on our Gitter chat.

In case you encounter failing tests during development, please check our developer FAQs!

Having any questions or issues? Feel free to ask here on GitHub. Need help setting up your local workspace? Join the conversation on JabRef's Gitter chat. And don't hesitate to open a (draft) pull request early on to show the direction it is heading towards. This way, you will receive valuable feedback.

Happy coding! 🚀

[koppor]

@Munhangyeol May I ask you about your timeline? This is kind of important as our tests are not green any more :)

[koppor]

@Munhangyeol When working on this, please update the sub modules and fix the mentioned tests. With #13429 I created a workaround PR to revert to the old state (which a working main branch)

[Munhangyeol]

@koppor I'm getting an error saying build-logic/java-module-packaging does not exist when trying to build.
I already updated submodules using git submodule update --init --recursive, but it didn't resolve the issue.
Do I need to do anything else?

[Munhangyeol]

@koppor I'm currently working on something else, but I think I can take care of it later this week.
Would that be too late? 😥