crossreferenced entry citekey changed when pasing into a new library

[ilippert]

JabRef version

Other (please describe below)

Operating system

GNU / Linux

Details on version and operating system

JabRef 5.14--2024-04-02--bb5ef81 Linux 6.7.9-200.fc39.x86_64 amd64 Java 21.0.2 JavaFX 22+30

Checked with the latest development build (copy version output from About dialog)

• I made a backup of my libraries before testing the latest development version.
• I have tested the latest development version and the problem persists

Steps to reproduce the behaviour

1. mark two entries, one of which crossreferences the other; while only the parent entry has a year/date information
2. copy both entries
3. paste in a new library

I find that the cite key of the child entry in the new library is generated without taking into account the parent entry('s date/year information) that is also copied.

This needs to be fixed, I guess, for #6404 to make sense.

[alpha951]

Hey, I'm looking for pickup my first issue. Could you please assign this to me?

[github-actions]

As a general advice for newcomers: check out Contributing for a start. Also, guidelines for setting up a local workspace is worth having a look at.

Feel free to ask here at GitHub, if you have any issue related questions. If you have questions about how to setup your workspace use JabRef's Gitter chat. Try to open a (draft) pull-request early on, so that people can see you are working on the issue and so that they can see the direction the pull request is heading towards. This way, you will likely receive valuable feedback.

[alpha951]

Hey, I'm new to this project. I've successfully setup the project in my local machine. I'm using a Manjaro Linux machine.

• mark two entries, one of which crossreferences the other; while only the parent entry has a year/date information

I tried to reproduce the issue. But couldn't notice the expected issue.

Here are the entries in first library :

Parent entry

@Article{Carpenter2024,
  author  = {Keshav Carpenter},
  journal = {Spring},
  title   = {Demo to reproduce github issue},
  year    = {2024},
}

Child entry

@Article{Keshav,
  author   = {Child Keshav},
  journal  = {Linuxtalks},
  title    = {Demo-2 to create child entry},
  crossref = {Carpenter2024},
}

On pasted in new library :

The year information is reflecting in child entry.

It got pasted as the original library.

@Article{Keshav2024,
  author   = {Child Keshav},
  journal  = {Linuxtalks},
  title    = {Demo-2 to create child entry},
  crossref = {Carpenter2024},
}

Hey @ilippert, please let me know if there is anything I missed while reproducing the issue.

[ilippert]

thanks for checking. I just used your entries and pasted these into my library. And already at this point it does not work. The reason being here maybe:
the library's default citekey pattern changes the parent's citekey information BEFORE going through the set of pasted entries and checking whether any citeky in the (I suppose) buffer is crossreferenced. I guess if a citekey is updated in the pasting process also the crossreferencing entries need to be adapted.

Sorry, not sure whether this makes sense - happy to spend some more time, in 2 weeks, as alas, right now I cannot take 20 minutes to spell this out in more systematic ways. Thanks for your understanding.

[alpha951]

Alright, so one thing I got, in my case the citekey of child entry in new library changes from
Keshav to Keshav2024.
So is this the issue ?
Also the child entry shows the year 2024 in new library since it's crossref to it's parent entry which has year as 2024. Is this expected or it's a bug ?
This confirmation will help me in starting out with debugging.
Thanks