Refactor:renamed path validity method & put placeholders in properties listeners

Author: raquelgraos

jabgui/src/main/java/org/jabref/gui/mergebibfilesintocurrentbib/MergeBibFilesIntoCurrentBibAction.java

@@ -156,7 +156,7 @@ private void mergeEntries(List<BibEntry> entries) {
     }
 
     private List<Path> getAllBibFiles(Path directory, Path databasePath) {
-        if (!checkPathValidity(directory)) {
+        if (!isValidPath(directory)) {
             return List.of();
         }
         try (Stream<Path> stream = Files.find(
@@ -172,7 +172,7 @@ private List<Path> getAllBibFiles(Path directory, Path databasePath) {
         return List.of();
     }
 
-    private boolean checkPathValidity(Path directory) {
+    private boolean isValidPath(Path directory) {
         if (!Files.exists(directory)) {
             dialogService.showErrorDialogAndWait(Localization.lang("Chosen folder does not exist:") + " " + directory);
             return false;

jabgui/src/main/java/org/jabref/gui/preferences/JabRefGuiPreferences.java

@@ -1323,8 +1323,8 @@ public MergeBibFilesIntoCurrentBibPreferences getMergeBibFilesIntoCurrentBibPref
                 getBoolean(MERGE_DUPLICATE_ENTRIES)
         );
 
-        EasyBind.listen(mergeBibFilesIntoCurrentBibPreferences.shouldMergeSameKeyEntriesProperty(), (obs, oldValue, newValue) -> putBoolean(MERGE_SAME_KEY_ENTRIES, newValue));
-        EasyBind.listen(mergeBibFilesIntoCurrentBibPreferences.shouldMergeDuplicateEntriesProperty(), (obs, oldValue, newValue) -> putBoolean(MERGE_DUPLICATE_ENTRIES, newValue));
+        EasyBind.listen(mergeBibFilesIntoCurrentBibPreferences.shouldMergeSameKeyEntriesProperty(), (_, _, newValue) -> putBoolean(MERGE_SAME_KEY_ENTRIES, newValue));
+        EasyBind.listen(mergeBibFilesIntoCurrentBibPreferences.shouldMergeDuplicateEntriesProperty(), (_, _, newValue) -> putBoolean(MERGE_DUPLICATE_ENTRIES, newValue));
 
         return mergeBibFilesIntoCurrentBibPreferences;
     }