Skip to content

Commit c51a916

Browse files
kopporsubhramit
andauthored
Refine PR Template (JabRef#13316)
Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
1 parent e41fb7e commit c51a916

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,17 @@
1-
Closes #_____
1+
Closes _____
2+
<!-- LINK THE ISSUE WITH THE "Closes" KEYWORD. Example: Closes https://github.com/JabRef/jabref/issues/13109 OR Closes #13109 -->
23

3-
In about one to three sentences, describe the changes you have made: what, where, why, ...
4+
<!-- In about one to three sentences, describe the changes you have made: what, where, why, ... (REPLACE THIS LINE) -->
45

56
<!-- NOTE: If your work is not yet complete, please open a draft pull request. In that case, outline your intended next steps. Do you need feedback? Will you continue in parallel? ... -->
67

78
### Steps to test
89

9-
Describe how reviewers can test this fix/feature. Ideally, think of how you would guide a beginner user of Jabef to try out your change.
10-
You can add screenshots or videos (using [Loom](https://www.loom.com/) or by just adding .mp4 files).
10+
<!-- Describe how reviewers can test this fix/feature. Ideally, think of how you would guide a beginner user of Jabef to try out your change. -->
11+
<!-- You can add screenshots or videos (using Loom - https://www.loom.com or by just adding .mp4 files). -->
12+
<!-- (REPLACE THIS PARAGRAPH) -->
1113

1214
<!-- YOU HAVE TO MODIFY THE ABOVE TEXT FIT YOUR PR. OTHERWISE, YOUR PR WILL BE CLOSED WITHOUT FURTHER COMMENT. -->
13-
<!-- LINK THE ISSUE WITH THE "Closes" KEYWORD. Example: Closes (link) OR Closes #12345 -->
1415

1516
### Mandatory checks
1617

.github/workflows/on-pr-opened-updated.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,9 @@ jobs:
4141
ticketPrefix: '#'
4242
titleRegex: '^#(?<ticketNumber>\d+)'
4343
branchRegex: '^(?<ticketNumber>\d+)'
44-
# Matches GitHub's closes/fixes/resolves #{number}, but does not match our example `Closes #12345` in PULL_REQUEST_TEMPLATE
44+
# Matches GitHub's closes/fixes/resolves #{number}, but does not match our example `Closes #13109` in PULL_REQUEST_TEMPLATE
4545
# Also matches URLs that are wrapped in `<>`.
46-
bodyRegex: '(?<action>fixes|closes|resolves|refs)\s+<?(?:https?:\/\/github\.com\/JabRef\/jabref\/issues\/)?#?(?<ticketNumber>(?!12345\b)\d+)>?'
46+
bodyRegex: '(?<action>fixes|closes|resolves|refs)\s+<?(?:https?:\/\/github\.com\/JabRef\/jabref\/issues\/)?#?(?<ticketNumber>(?!13109\b)\d+)>?'
4747
bodyRegexFlags: 'i'
4848
outputOnly: true
4949
- run: echo "${{ steps.get_issue_number.outputs.ticketNumber }}"

0 commit comments

Comments
 (0)