From a7fd8f54ac79cb558508a90f0b73d3b82427f412 Mon Sep 17 00:00:00 2001 From: HRASTNIK Patrick Ing Date: Thu, 8 Aug 2019 09:20:08 +0200 Subject: [PATCH 1/5] Added types implementation Suggested fix for #75 Signed-off-by: HRASTNIK Patrick Ing --- lib/itoolkit.js | 24 +++++++++++++++++++++++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/lib/itoolkit.js b/lib/itoolkit.js index d78c9634..f679ddf8 100644 --- a/lib/itoolkit.js +++ b/lib/itoolkit.js @@ -569,7 +569,29 @@ class iSql { } } - +exports.types = { + char(countChars) { + return countChars.toString() + "A"; + }, + packed(digits, delimiter) { + return digits.toString() + "P" + delimiter.toString(); + }, + zoned(digits, delimiter) { + return digits.toString() + "S" + delimiter.toString(); + }, + signed(digits, delimiter) { + return digits.toString() + "I" + delimiter.toString(); + }, + unsigned(digits, delimiter) { + return digits.toString() + "U" + delimiter.toString(); + }, + float(digits, delimiter) { + return digits.toString() + "F" + delimiter.toString(); + }, + binary(countBytes) { + return countBytes.toString() + "B"; + } +}; exports.iConn = iConn; exports.iCmd = iCmd; From 5b23b11dac4ed2dedf2ca0188a625314c6299272 Mon Sep 17 00:00:00 2001 From: patrickhrastnik <30524365+patrickhrastnik@users.noreply.github.com> Date: Fri, 4 Oct 2019 20:18:48 +0200 Subject: [PATCH 2/5] Update lib/itoolkit.js Applied suggestion from @kadler Co-Authored-By: Kevin Adler --- lib/itoolkit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/itoolkit.js b/lib/itoolkit.js index f679ddf8..552bc63a 100644 --- a/lib/itoolkit.js +++ b/lib/itoolkit.js @@ -571,7 +571,7 @@ class iSql { exports.types = { char(countChars) { - return countChars.toString() + "A"; + return length.toString() + "A"; }, packed(digits, delimiter) { return digits.toString() + "P" + delimiter.toString(); From 917e4ade310f0164e5aab3a4ce17a4e7251fdb95 Mon Sep 17 00:00:00 2001 From: patrickhrastnik <30524365+patrickhrastnik@users.noreply.github.com> Date: Fri, 4 Oct 2019 20:18:57 +0200 Subject: [PATCH 3/5] Update lib/itoolkit.js Applied suggestion from @kadler Co-Authored-By: Kevin Adler --- lib/itoolkit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/itoolkit.js b/lib/itoolkit.js index 552bc63a..b55fef8c 100644 --- a/lib/itoolkit.js +++ b/lib/itoolkit.js @@ -570,7 +570,7 @@ class iSql { } exports.types = { - char(countChars) { + char(length) { return length.toString() + "A"; }, packed(digits, delimiter) { From 6463342cc437c5f7d7c5f0965f37d22962a7c645 Mon Sep 17 00:00:00 2001 From: patrickhrastnik <30524365+patrickhrastnik@users.noreply.github.com> Date: Fri, 4 Oct 2019 20:19:07 +0200 Subject: [PATCH 4/5] Update lib/itoolkit.js Applied suggestion from @kadler Co-Authored-By: Kevin Adler --- lib/itoolkit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/itoolkit.js b/lib/itoolkit.js index b55fef8c..9321a21a 100644 --- a/lib/itoolkit.js +++ b/lib/itoolkit.js @@ -589,7 +589,7 @@ exports.types = { return digits.toString() + "F" + delimiter.toString(); }, binary(countBytes) { - return countBytes.toString() + "B"; + return length.toString() + "B"; } }; From e51888ade709fdd9fe9017c68062db0fc502b651 Mon Sep 17 00:00:00 2001 From: patrickhrastnik <30524365+patrickhrastnik@users.noreply.github.com> Date: Fri, 4 Oct 2019 20:19:15 +0200 Subject: [PATCH 5/5] Update lib/itoolkit.js Applied suggestion from @kadler Co-Authored-By: Kevin Adler --- lib/itoolkit.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/itoolkit.js b/lib/itoolkit.js index 9321a21a..137cec85 100644 --- a/lib/itoolkit.js +++ b/lib/itoolkit.js @@ -588,7 +588,7 @@ exports.types = { float(digits, delimiter) { return digits.toString() + "F" + delimiter.toString(); }, - binary(countBytes) { + binary(length) { return length.toString() + "B"; } };