Refactor Token Generation Logic to improve readability #1081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Moved toJson methods into IdentityResponse from UIDOperatorVerticle class
…stead of ITokenEncoder interfact so it's easier to jump to references and we haven't really created any other ITokenEncoder variants
…59-token-gen-code-refactoring
…59-token-gen-code-refactoring
2. Renamed RawUidResult to RawUidResponse 3. rename some id variable to rawUid to make it clearer 4. more comments
…xed the UserIdentity/FirstLevelHashIdentity class uses to HashedDiiIdentity instead in IdentityMapBenchmark and TokenEndecBenchmark
…aming' into syw-UID2-4159-token-gen-code-refactoring
…aming' into syw-UID2-4159-token-gen-code-refactoring
currently set to the same value as the AdvertisingTokenInput/RefreshTokenInput#createdAt timestamp. 2. Renamed some `token` variable names to adTokenInput and refreshTokenInput to make it clearer
…aming' into syw-UID2-4159-token-gen-code-refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.