-
-
Notifications
You must be signed in to change notification settings - Fork 2
integrate eslint #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
odama626
merged 6 commits into
FlatbreadLabs:main
from
odama626:all-the-eslint-none-of-the-fixes
Aug 16, 2022
Merged
integrate eslint #81
odama626
merged 6 commits into
FlatbreadLabs:main
from
odama626:all-the-eslint-none-of-the-fixes
Aug 16, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 2, 2022
Closed
Looking great! Before this goes in, we should:
Then after this goes in, we can:
|
only 4 errors remain, and its around types 29:33 error Don't use `object` as a type. The `object` type is currently hard to use ([see this issue](https://github.com/microsoft/TypeScript/issues/21732)).
Consider using `Record<string, unknown>` instead, as it allows you to more easily inspect and use the keys @typescript-eslint/ban-types
30:26 error Don't use `object` as a type. The `object` type is currently hard to use ([see this issue](https://github.com/microsoft/TypeScript/issues/21732)).
Consider using `Record<string, unknown>` instead, as it allows you to more easily inspect and use the keys @typescript-eslint/ban-types
32:25 error Don't use `object` as a type. The `object` type is currently hard to use ([see this issue](https://github.com/microsoft/TypeScript/issues/21732)).
Consider using `Record<string, unknown>` instead, as it allows you to more easily inspect and use the keys @typescript-eslint/ban-types
✖ 97 problems (4 errors, 93 warnings)``` |
Nice one! Excited for this since it'll keep us in line & up our code standards |
can we get this in? it's non-breaking, just really looking forward having pretty-quick |
it's non breaking because lint:eslint isn't used by lint currently |
tonyketcham
approved these changes
Aug 12, 2022
Yup - sorry for the delay on approving this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #34
this adds eslint and moves to pretty-quick for prettier, but doesn't enable eslint yet -- want to get some of @tonyketcham's big Prs in first