From 93420f7d009fd7a572026a56c6a419aef3877451 Mon Sep 17 00:00:00 2001 From: Hetansh Madhani Date: Fri, 31 Jan 2020 10:30:40 -0500 Subject: [PATCH] [PROD] Update RDS func to deal with empty name tag Currently filesystem metrics -> aws.rds.filesystem.* metrics are being tagged with a empty 'name:' tag. This happens because we are trying to parse the name key's value from the "fileSys" section of the log event, but it has an empty values as seen here: https://a.cl.ly/v1um7p1z which results in an empty tag like this: https://a.cl.ly/WnuEgNNn I think my change will not add the `name` tag if it has an empty value. --- aws/rds_enhanced_monitoring/lambda_function.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/aws/rds_enhanced_monitoring/lambda_function.py b/aws/rds_enhanced_monitoring/lambda_function.py index 769f90677..9efe82e07 100644 --- a/aws/rds_enhanced_monitoring/lambda_function.py +++ b/aws/rds_enhanced_monitoring/lambda_function.py @@ -97,7 +97,11 @@ def _process_rds_enhanced_monitoring_message(ts, message, account, region): fs_tag = [] for tag_key in ["name", "mountPoint"]: if tag_key in fs_stats: - fs_tag.append("%s:%s" % (tag_key, fs_stats.pop(tag_key))) + tag_value = fs_stats.pop(tag_key) + if tag_value == '': + continue + else: + fs_tag.append("%s:%s" % (tag_key, tag_value)) for key, value in fs_stats.iteritems(): stats.gauge( 'aws.rds.filesystem.%s' % key, value,