scripts: ci: qemu-run.sh: make audio device optional #945

DaniilKl · 2025-07-17T08:48:07Z

The QEMU audio device emulation caused issues in github.com/dasharo/meta-dts testing CIs. Check this issue for more inf.: Dasharo/dasharo-issues#1382 . Because the audio device is not used in the CIs - it could be disabled optionally.

The QEMU audio device emulation caused issues in github.com/dasharo/meta-dts testing CIs. Check this issue for more inf.: Dasharo/dasharo-issues#1382 . Because the audio device is not used in the CIs - it could be disabled optionally. Signed-off-by: Daniil Klimuk <daniil.klimuk@3mdeb.com>

The change is caused by: codespell................................................................Failed - hook id: codespell - exit code: 65 scripts/ci/qemu-run.sh:161: hda ==> had Signed-off-by: Daniil Klimuk <daniil.klimuk@3mdeb.com>

.codespellrc

m-iwanicki · 2025-07-17T08:56:12Z

scripts/ci/qemu-run.sh

  -device virtio-rng-pci,max-bytes=1024,period=1000 \
  -device virtio-net,netdev=vmnic \
  -netdev user,id=vmnic,hostfwd=tcp::5222-:22 \
  -drive file=${HDD_PATH},if=ide"

+QEMU_PARAMS_OS_SAUND="-device ich9-intel-hda \


Suggested change

QEMU_PARAMS_OS_SAUND="-device ich9-intel-hda \

QEMU_PARAMS_OS_AUDIO="-device ich9-intel-hda \

m-iwanicki · 2025-07-17T08:57:19Z

scripts/ci/qemu-run.sh

@@ -22,6 +22,7 @@ then
    exit 1
 fi

+NO_AUDIO_EMUALTION=""


Suggested change

NO_AUDIO_EMUALTION=""

NO_AUDIO_EMULATION=""

m-iwanicki · 2025-07-17T08:58:19Z

scripts/ci/qemu-run.sh

@@ -38,7 +39,7 @@ QEMU_FW_FILE="./qemu_q35.rom"

 usage() {
 cat <<EOF
-Usage: ./$(basename ${0}) QEMU_MODE ACTION
+Usage: ./$(basename ${0}) QEMU_MODE ACTION ARGUMENTS


Suggested change

Usage: ./$(basename ${0}) QEMU_MODE ACTION ARGUMENTS

Usage: ./$(basename ${0}) [OPTIONS]... QEMU_MODE ACTION

m-iwanicki · 2025-07-17T08:58:34Z

scripts/ci/qemu-run.sh

@@ -62,6 +63,10 @@ This is the QEMU wrapper script for the Dasharo Open Source Firmware Validation.
    HDD2_PATH   optional path of the second hard drive to connect to the machine if
                ACTION "os" is used. Relative to DIR

+  Additional ARGUMENTS:


Suggested change

Additional ARGUMENTS:

OPTIONS:

m-iwanicki · 2025-07-17T09:01:36Z

scripts/ci/qemu-run.sh

@@ -129,10 +134,6 @@ cleanup() {

 trap cleanup INT



Suggested change

parse_args() {

while [[ $# -gt 0 ]]; do

case $1 in

-v|--verbose)

set -x

shift

;;

-h|--help)

usage

exit 0

;;

-*)

usage

echo "Unknown option $1"

exit 1

;;

*)

POSITIONAL_ARGS+=( "$1" )

shift

;;

esac

done

}

parse_args "$@"

set -- "${POSITIONAL_ARGS[@]}"

That way:

You don't need to remove next if

You can use arguments anywhere

If you apply then bring back

if [ $# -ne 2 ]; then usage fi

And add --help and --verbose to usage.
I mostly use this template: https://github.com/m-iwanicki/scripts/blob/main/scripts/script-template.sh when writing scripts.

m-iwanicki · 2025-07-17T09:03:12Z

scripts/ci/qemu-run.sh

+ACTION="$2"
+shift 2
+
+# Check for additional parameters before deciding on QEMU_PARAMS. Because the
+# additional parameters might change the QEMU_PARAMS.
+while [[ $# -gt 0 ]]; do
+  case $1 in
+    "--no-audio-emulation")
+      NO_AUDIO_EMUALTION="true"
+      shift
+		;;
+    *)
+      echo -e "Additional argument: ${1} not supported\n"
+      usage
+      exit 1
+		;;
+  esac
+done


Suggested change

ACTION="$2"

shift 2

# Check for additional parameters before deciding on QEMU_PARAMS. Because the

# additional parameters might change the QEMU_PARAMS.

while [[ $# -gt 0 ]]; do

case $1 in

"--no-audio-emulation")

NO_AUDIO_EMUALTION="true"

shift

;;

*)

echo -e "Additional argument: ${1} not supported\n"

usage

exit 1

;;

esac

done

Implement previous suggestion

m-iwanicki · 2025-07-17T09:12:18Z

.codespellx

@@ -2,6 +2,7 @@
 #


Remove everything from this file and add hda to .codespellrc file

correct .codespellrc format: #945 (comment)

m-iwanicki · 2025-07-17T09:15:18Z

scripts/ci/qemu-run.sh

+while [[ $# -gt 0 ]]; do
+  case $1 in
+    "--no-audio-emulation")
+      NO_AUDIO_EMUALTION="true"


Suggested change

NO_AUDIO_EMUALTION="true"

NO_AUDIO_EMULATION="true"

m-iwanicki · 2025-07-17T09:15:29Z

scripts/ci/qemu-run.sh

 case "${ACTION}" in
  firmware)
    MEMORY="1G"
 		;;
  os)
    MEMORY="4G"
    QEMU_PARAMS="${QEMU_PARAMS} ${QEMU_PARAMS_OS}"
+
+    if [[ "$NO_AUDIO_EMUALTION" != "true" ]]; then


Suggested change

if [[ "$NO_AUDIO_EMUALTION" != "true" ]]; then

if [[ "$NO_AUDIO_EMULATION" != "true" ]]; then

m-iwanicki · 2025-07-17T09:16:29Z

scripts/ci/qemu-run.sh

 case "${ACTION}" in
  firmware)
    MEMORY="1G"
 		;;
  os)
    MEMORY="4G"
    QEMU_PARAMS="${QEMU_PARAMS} ${QEMU_PARAMS_OS}"
+
+    if [[ "$NO_AUDIO_EMUALTION" != "true" ]]; then
+      QEMU_PARAMS="${QEMU_PARAMS} ${QEMU_PARAMS_OS_SAUND}"


Suggested change

QEMU_PARAMS="${QEMU_PARAMS} ${QEMU_PARAMS_OS_SAUND}"

QEMU_PARAMS="${QEMU_PARAMS} ${QEMU_PARAMS_OS_AUDIO}"

DaniilKl requested a review from m-iwanicki July 17, 2025 08:48

DaniilKl self-assigned this Jul 17, 2025

.codespell*: exclude "hda"

8fa988e

The change is caused by: codespell................................................................Failed - hook id: codespell - exit code: 65 scripts/ci/qemu-run.sh:161: hda ==> had Signed-off-by: Daniil Klimuk <daniil.klimuk@3mdeb.com>

DaniilKl force-pushed the optional-audio-device-qemu branch from 4da57cc to 8fa988e Compare July 17, 2025 09:05

m-iwanicki requested changes Jul 17, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

scripts: ci: qemu-run.sh: make audio device optional #945

scripts: ci: qemu-run.sh: make audio device optional #945

Uh oh!

DaniilKl commented Jul 17, 2025 •

edited

Loading

Uh oh!

Uh oh!

m-iwanicki Jul 17, 2025

Uh oh!

m-iwanicki Jul 17, 2025

Uh oh!

m-iwanicki Jul 17, 2025

Uh oh!

m-iwanicki Jul 17, 2025

Uh oh!

m-iwanicki Jul 17, 2025

Uh oh!

m-iwanicki Jul 17, 2025

Uh oh!

m-iwanicki Jul 17, 2025

Uh oh!

m-iwanicki Jul 17, 2025

Uh oh!

m-iwanicki Jul 17, 2025

Uh oh!

m-iwanicki Jul 17, 2025

Uh oh!

m-iwanicki Jul 17, 2025

Uh oh!

Uh oh!

	QEMU_PARAMS_OS_SAUND="-device ich9-intel-hda \
	QEMU_PARAMS_OS_AUDIO="-device ich9-intel-hda \

	Usage: ./$(basename ${0}) QEMU_MODE ACTION ARGUMENTS
	Usage: ./$(basename ${0}) [OPTIONS]... QEMU_MODE ACTION

+parse_args() {
+  while [[ $# -gt 0 ]]; do
+    case $1 in
+      -v|--verbose)
+        set -x
+        shift
+        ;;
+      -h|--help)
+        usage
+        exit 0
+        ;;
+      -*)
+        usage
+        echo "Unknown option $1"
+        exit 1
+        ;;
+      *)
+        POSITIONAL_ARGS+=( "$1" )
+        shift
+        ;;
+    esac
+  done
+}
+parse_args "$@"
+set -- "${POSITIONAL_ARGS[@]}"

	if [[ "$NO_AUDIO_EMUALTION" != "true" ]]; then
	if [[ "$NO_AUDIO_EMULATION" != "true" ]]; then

	QEMU_PARAMS="${QEMU_PARAMS} ${QEMU_PARAMS_OS_SAUND}"
	QEMU_PARAMS="${QEMU_PARAMS} ${QEMU_PARAMS_OS_AUDIO}"

Uh oh!

scripts: ci: qemu-run.sh: make audio device optional #945

Are you sure you want to change the base?

scripts: ci: qemu-run.sh: make audio device optional #945

Uh oh!

Conversation

DaniilKl commented Jul 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DaniilKl commented Jul 17, 2025 •

edited

Loading