Skip to content

Add support for checking if power LED lit up on APU platforms #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: seabios-support
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions keywords.robot
Original file line number Diff line number Diff line change
Expand Up @@ -745,6 +745,18 @@ Power Cycle On
END
IF '${DEFAULT_POWER_STATE_AFTER_FAIL}' == 'Powered Off' Rte Power On

IF '${CHECK_POWER_LED_SUPPORT}' == '${TRUE}'
FOR ${i} IN RANGE 10
${out}= Rte Check Power Led
IF '${out}' == 'high' RETURN
Sleep 0.5s
END
IF '${out}' != 'high'
FAIL Power LED didn't light up! Setup needs manual verification,
... or Power State After Power Failure is set incorrectly.
END
END

OBMC Power Cycle On
[Documentation] Clears obmc-console-client buffer and perform full power
... cycle with Chassis and Host State Control
Expand Down
14 changes: 13 additions & 1 deletion platform-configs/include/default.robot
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ ${INTERNAL_PROGRAMMER_CHIPNAME}= "Opaque flash chip"
${FLASHING_METHOD}= external
${SNIPEIT}= yes
${SEABIOS_BOOT_DEVICE}= ${EMPTY}
${CHECK_POWER_LED_SUPPORT}= ${TRUE}

# See: https://github.com/Dasharo/dasharo-issues/issues/614
${LAPTOP_EC_SERIAL_WORKAROUND}= ${FALSE}
Expand Down Expand Up @@ -280,6 +281,17 @@ Power On Default
IF '${DUT_CONNECTION_METHOD}' == 'SSH' RETURN
Sleep 2s
Rte Power Off
Sleep 10s
IF '${CHECK_POWER_LED_SUPPORT}' == '${TRUE}'
FOR ${i} IN RANGE 10
${out}= Rte Check Power Led
IF '${out}' == 'low' RETURN
Sleep 0.5s
END
IF '${out}' != 'low'
FAIL Power LED didn't turn off! Setup needs manual verification.
END
ELSE
Sleep 10s
END
Read From Terminal
Power Cycle On
1 change: 1 addition & 0 deletions platform-configs/include/msi-z690-common.robot
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ ${POWER_CTRL}= sonoff
${FLASH_VERIFY_METHOD}= none
${WIFI_CARD}= ${TBD}
${MAX_CPU_TEMP}= 80
${CHECK_POWER_LED_SUPPORT}= ${FALSE}

${DMIDECODE_MANUFACTURER}= Micro-Star International Co., Ltd.
${DMIDECODE_VENDOR}= 3mdeb
Expand Down
1 change: 1 addition & 0 deletions platform-configs/include/novacustom-common.robot
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ ${FLASH_VERIFY_METHOD}= none
${MAX_CPU_TEMP}= 82
${AUTO_BOOT_TIME_OUT_DEFAULT_VALUE}= 6
${FLASHING_METHOD}= internal
${CHECK_POWER_LED_SUPPORT}= ${FALSE}

${DMIDECODE_SERIAL_NUMBER}= N/A
${DMIDECODE_MANUFACTURER}= Notebook
Expand Down
1 change: 1 addition & 0 deletions platform-configs/include/optiplex-common.robot
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ ${SETUP_MENU_KEY}= ${F2}
${IPXE_BOOT_ENTRY}= Network Boot and Utilities
${POWER_CTRL}= sonoff
${MAX_CPU_TEMP}= 80
${CHECK_POWER_LED_SUPPORT}= ${FALSE}

${DMIDECODE_VENDOR}= 3mdeb
${DMIDECODE_FAMILY}= N/A
Expand Down
10 changes: 10 additions & 0 deletions platform-configs/include/pcengines-seabios.robot
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
*** Settings ***
Resource pcengines.robot


*** Variables ***
${BIOS_LIB}= seabios
${FW_STRING}= F10
${SEABIOS_BOOT_DEVICE}= 4
${BOOT_MENU_KEY}= ${F10}
${TESTS_IN_FIRMWARE_SUPPORT}= ${FALSE}
5 changes: 5 additions & 0 deletions platform-configs/include/pcengines.robot
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,8 @@ ${USB_TYPE-A_DEVICES_DETECTION_SUPPORT}= ${TRUE}

# Test module: trenchboot
${TRENCHBOOT_SUPPORT}= ${TRUE}


*** Keywords ***
Power On
Power On Default
6 changes: 6 additions & 0 deletions platform-configs/pcengines-apu2-seabios.robot
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
*** Settings ***
Resource include/pcengines-seabios.robot


*** Variables ***
${DMIDECODE_PRODUCT_NAME}= apu2
6 changes: 6 additions & 0 deletions platform-configs/pcengines-apu3-seabios.robot
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
*** Settings ***
Resource include/pcengines-seabios.robot


*** Variables ***
${DMIDECODE_PRODUCT_NAME}= apu3
6 changes: 6 additions & 0 deletions platform-configs/pcengines-apu4-seabios.robot
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
*** Settings ***
Resource include/pcengines-seabios.robot


*** Variables ***
${DMIDECODE_PRODUCT_NAME}= apu4
6 changes: 6 additions & 0 deletions platform-configs/pcengines-apu6-seabios.robot
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
*** Settings ***
Resource include/pcengines-seabios.robot


*** Variables ***
${DMIDECODE_PRODUCT_NAME}= apu6
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ MarkupSafe==2.1.5
mdurl==0.1.2
nodeenv==1.8.0
oauth2client==4.1.3
osfv @ git+https://github.com/Dasharo/osfv-scripts.git@36a030eb006391c3761c25d6972036a5a34fb73b#subdirectory=osfv_cli
osfv @ git+https://github.com/Dasharo/osfv-scripts.git@06bf5d45b21bdec86486aba8aafd5664d470beff#subdirectory=osfv_cli
paramiko==3.4.0
pathspec==0.9.0
pexpect==4.9.0
Expand Down
Loading