configs/config.novacustom_*: enable capsule updates #651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkopec
force-pushed
the
ncm_capsule
branch
14 times, most recently
from
5ddbf6a to
f4d8d7c
Compare
mkopec
force-pushed
the
ncm_capsule
branch
2 times, most recently
from
6d3bed2 to
4546692
Compare
There was a problem hiding this comment.
Needs a bit of squashing but otherwise LGTM. Not approving just because Dasharo/open-source-firmware-validation#800 is in progress.
@BeataZdunczyk suggests using manual tests as proof that it works: Update in progress ESRT Table after update Let's get this merged so that we can prepare a new RC for testing capsules |
Upstream-Status: Inappropriate (Dasharo downstream) Change-Id: Ia9675d4a9e4259b1e88180931a03f6d314afaf68 Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com> Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
Upstream-Status: Inappropriate (Dasharo downstream) Change-Id: I5dcf598ff91bdc3326bb0f7ebd73948db55c91a1 Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Upstream-Status: Inappropriate (Dasharo downstream) Change-Id: I8c3a5a5e2bb659e5caf120ef784e887a7ae8a6ef Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Upstream-Status: Inappropriate (Dasharo downstream) Change-Id: I55dc4c6bc4682f2a140f2d34940eee4a2e5aa46f Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
Change-Id: I9f3f198bfedc7b4baf2dd848cd0f3a4effc46a35 Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
SergiiDmytruk
force-pushed
the
ncm_capsule
branch
from
9e889c6 to
9f9d71d
Compare
|
OK, took another look and:
Waiting for CI. |
SergiiDmytruk
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Ia9675d4a9e4259b1e88180931a03f6d314afaf68
Needs Dasharo/edk2#238