From 905feaf51ebb5c1b6ade40beed4b1e466eef5d03 Mon Sep 17 00:00:00 2001 From: Aaron Powell Date: Tue, 15 Apr 2025 13:59:31 +1000 Subject: [PATCH 1/3] updating Deno version Hoping to fix #377 --- .github/actions/setup-runtimes-caching/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/setup-runtimes-caching/action.yml b/.github/actions/setup-runtimes-caching/action.yml index ca5f9cbc..2886f9a9 100644 --- a/.github/actions/setup-runtimes-caching/action.yml +++ b/.github/actions/setup-runtimes-caching/action.yml @@ -66,7 +66,7 @@ runs: - uses: denoland/setup-deno@v2 name: Setup Deno with: - deno-version: v2.1.4 + deno-version: v2.2.10 - uses: oven-sh/setup-bun@v2 name: Setup Bun From a3f87b9a4f91433214c92009c205e98ab380a498 Mon Sep 17 00:00:00 2001 From: Aaron Powell Date: Tue, 15 Apr 2025 14:14:27 +1000 Subject: [PATCH 2/3] Updating how deno tests assert --- .../CommunityToolkit.Aspire.Hosting.Deno.AppHost/Program.cs | 6 ++++-- .../AppHostTests.cs | 4 ++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/examples/deno/CommunityToolkit.Aspire.Hosting.Deno.AppHost/Program.cs b/examples/deno/CommunityToolkit.Aspire.Hosting.Deno.AppHost/Program.cs index 8301a840..cfaf8490 100644 --- a/examples/deno/CommunityToolkit.Aspire.Hosting.Deno.AppHost/Program.cs +++ b/examples/deno/CommunityToolkit.Aspire.Hosting.Deno.AppHost/Program.cs @@ -5,10 +5,12 @@ builder.AddDenoTask("vite-demo", taskName: "dev") .WithDenoPackageInstallation() .WithHttpEndpoint(env: "PORT") - .WithEndpoint(); + .WithEndpoint() + .WithHttpHealthCheck("/"); builder.AddDenoApp("oak-demo", "main.ts", permissionFlags: ["-E", "--allow-net"]) .WithHttpEndpoint(env: "PORT") - .WithEndpoint(); + .WithEndpoint() + .WithHttpHealthCheck("/"); builder.Build().Run(); diff --git a/tests/CommunityToolkit.Aspire.Hosting.Deno.Tests/AppHostTests.cs b/tests/CommunityToolkit.Aspire.Hosting.Deno.Tests/AppHostTests.cs index 436409bf..369cfb29 100644 --- a/tests/CommunityToolkit.Aspire.Hosting.Deno.Tests/AppHostTests.cs +++ b/tests/CommunityToolkit.Aspire.Hosting.Deno.Tests/AppHostTests.cs @@ -11,7 +11,7 @@ public async Task ResourceStartsAndRespondsOk() var appName = "vite-demo"; var httpClient = fixture.CreateHttpClient(appName); - await fixture.App.WaitForTextAsync("VITE", appName).WaitAsync(TimeSpan.FromSeconds(30)); + await fixture.ResourceNotificationService.WaitForResourceHealthyAsync(appName).WaitAsync(TimeSpan.FromMinutes(5)); var response = await httpClient.GetAsync("/"); @@ -24,7 +24,7 @@ public async Task ApiResourceStartsAndRespondsOk() var appName = "oak-demo"; var httpClient = fixture.CreateHttpClient(appName); - await fixture.App.WaitForTextAsync("Server listening on port ", appName).WaitAsync(TimeSpan.FromSeconds(30)); + await fixture.ResourceNotificationService.WaitForResourceHealthyAsync(appName).WaitAsync(TimeSpan.FromMinutes(5)); var response = await httpClient.GetAsync("/weather"); From f25e59cf573b85e772b463e6667a10887a471a5e Mon Sep 17 00:00:00 2001 From: Aaron Powell Date: Fri, 16 May 2025 14:52:42 +1000 Subject: [PATCH 3/3] Updating Deno version --- .github/actions/setup-runtimes-caching/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/setup-runtimes-caching/action.yml b/.github/actions/setup-runtimes-caching/action.yml index 2886f9a9..2401a2fb 100644 --- a/.github/actions/setup-runtimes-caching/action.yml +++ b/.github/actions/setup-runtimes-caching/action.yml @@ -66,7 +66,7 @@ runs: - uses: denoland/setup-deno@v2 name: Setup Deno with: - deno-version: v2.2.10 + deno-version: v2.3.2 - uses: oven-sh/setup-bun@v2 name: Setup Bun