Skip to content

Commit 72d63a2

Browse files
committed
chore(merge): dotting the is
1 parent baa177b commit 72d63a2

File tree

4 files changed

+541
-3236
lines changed

4 files changed

+541
-3236
lines changed

README.md

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -33,23 +33,14 @@ Truffle
3333
3. In terminal```truffle migrate```
3434

3535
#### Deploying to Matic
36-
1. ```npm install truffle -g```
37-
38-
Mumbai Testnet configured in ```./truffle-config.js```
39-
40-
Test deployment using Truffle against a runnning Ganache instance: ```truffle migrate```
41-
Deploy to Mumbai testnet: ```truffle migrate --network matic```
42-
43-
Verify contract address at the [Matic Explorer](https://explorer-mumbai.maticvigil.com/)
36+
Deployment to the Mumbai Testnet is configured in ```./truffle-config.js```
4437

45-
*Verifying & publishing the contract code*
46-
47-
In the [Matic Explorer](https://explorer-mumbai.maticvigil.com/) find your contract based on the address reported by Truffle.
48-
Go to the tab ```Code```
49-
50-
Flattening contract: https://github.com/poanetwork/solidity-flattener and cleanup SPDX licenses and _Chainlink appended to classes like SafeMath, Buffer and ENSResolver
38+
1. ```npm install truffle -g```
39+
2. Deploy to Mumbai testnet: ```truffle migrate --network matic```
40+
3. Find your contract based on the address reported by Truffle in the [Matic Explorer](https://explorer-mumbai.maticvigil.com/).
5141

52-
Quite note on setting up Matic:
42+
Quite note on deploying to Matic:
43+
* Test deployment using Truffle against a runnning Ganache instance: ```truffle migrate```
5344
* Configure Matic network in [MetaMask](https://docs.matic.network/docs/develop/metamask/config-matic/)
5445
* Request funds at [faucet](https://faucet.matic.network/)
5546
* Use this wallet's seed phrase in the .env file to pay the deployment
@@ -69,7 +60,7 @@ After deploying to a local node
6960
Example for interacting:
7061
```await commitPool.withdraw(1000)```
7162
## Features
72-
[Technical documentation](https://ipfs.io/ipfs/QmdJsGYi822G1azEMtGL39LRwXZtJRC58KT393TGPixP6z)
63+
[Technical documentation](https://ipfs.io/ipfs/https://ipfs.io/ipfs/QmVrBwsQ67RE9CVzyQRvDucK4LrjgB7tkAserztyBDNfJi)
7364
#### Creation of Commitment
7465

7566
A commitment consists of an ```activity```, a ```goalValue``` for given activity, a ```startTime```, and ```stake```. We will automagically set the ```endTime``` 7 days after the startdate.

contracts/SinglePlayerCommit.sol

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,7 @@ contract SinglePlayerCommit is ChainlinkClient, Ownable {
274274
/// @notice Internal function for evaluating commitment and slashing funds if needed
275275
/// @dev Receive call with commitment object from storage
276276
function _settleCommitment(Commitment storage commitment) internal returns (bool success) {
277-
commitment.met = commitment.reportedValue > commitment.goalValue;
277+
commitment.met = commitment.reportedValue >= commitment.goalValue;
278278

279279
if (!commitment.met) {
280280
_slashFunds(commitment.stake, msg.sender);
@@ -481,7 +481,7 @@ contract SinglePlayerCommit is ChainlinkClient, Ownable {
481481

482482
/// @notice Get address for ChainLink token contract
483483
/// @dev ChainLink contract method
484-
function getChainlinkToken() public view returns (address chainlinkTokenAddress) {
484+
function getChainlinkToken() public view returns (address tokenAddress) {
485485
return chainlinkTokenAddress();
486486
}
487487

0 commit comments

Comments
 (0)