From 37970fa4e28739df3d9c4df6ef3865959989a464 Mon Sep 17 00:00:00 2001 From: eediallo Date: Fri, 13 Jun 2025 11:06:40 +0100 Subject: [PATCH 1/3] Refactor find_longest_common_prefix to use to improved efficiency using precomputing --- .../common_prefix/common_prefix.py | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py b/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py index f4839e7..9f4ec9b 100644 --- a/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py +++ b/Sprint-2/improve_with_precomputing/common_prefix/common_prefix.py @@ -7,12 +7,15 @@ def find_longest_common_prefix(strings: List[str]): In the event that an empty list, a list containing one string, or a list of strings with no common prefixes is passed, the empty string will be returned. """ + if len(strings) < 2: + return "" + # Precompute: sort the strings so common prefixes are adjacent + sorted_strings = sorted(strings) longest = "" - for string_index, string in enumerate(strings): - for other_string in strings[string_index+1:]: - common = find_common_prefix(string, other_string) - if len(common) > len(longest): - longest = common + for i in range(len(sorted_strings) - 1): + common = find_common_prefix(sorted_strings[i], sorted_strings[i + 1]) + if len(common) > len(longest): + longest = common return longest From d55498e9d228ac11994d4623ac90320b5fa5f808 Mon Sep 17 00:00:00 2001 From: eediallo Date: Fri, 13 Jun 2025 11:18:36 +0100 Subject: [PATCH 2/3] Refactor count_letters to improve efficiency by precomputing letter sets --- .../count_letters/count_letters.py | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/Sprint-2/improve_with_precomputing/count_letters/count_letters.py b/Sprint-2/improve_with_precomputing/count_letters/count_letters.py index 62c3ec0..ccc16f9 100644 --- a/Sprint-2/improve_with_precomputing/count_letters/count_letters.py +++ b/Sprint-2/improve_with_precomputing/count_letters/count_letters.py @@ -2,13 +2,13 @@ def count_letters(s: str) -> int: """ count_letters returns the number of letters which only occur in upper case in the passed string. """ - only_upper = set() - for letter in s: - if is_upper_case(letter): - if letter.lower() not in s: - only_upper.add(letter) + # Precompute all lowercase and uppercase letters in the string + lower_set = set(c for c in s if c.islower()) + upper_set = set(c for c in s if c.isupper()) + # Only count uppercase letters that do not have a lowercase version in the string + only_upper = {c for c in upper_set if c.lower() not in lower_set} return len(only_upper) -def is_upper_case(letter: str) -> bool: - return letter == letter.upper() +def is_upper_case(letter: str) -> str: + return letter.upper() From d49987d7b9352bbdac1fee1cdee66d742a5168cd Mon Sep 17 00:00:00 2001 From: eediallo Date: Fri, 13 Jun 2025 11:19:05 +0100 Subject: [PATCH 3/3] Remove unused is_upper_case function from count_letters.py --- .../improve_with_precomputing/count_letters/count_letters.py | 4 ---- 1 file changed, 4 deletions(-) diff --git a/Sprint-2/improve_with_precomputing/count_letters/count_letters.py b/Sprint-2/improve_with_precomputing/count_letters/count_letters.py index ccc16f9..892f737 100644 --- a/Sprint-2/improve_with_precomputing/count_letters/count_letters.py +++ b/Sprint-2/improve_with_precomputing/count_letters/count_letters.py @@ -8,7 +8,3 @@ def count_letters(s: str) -> int: # Only count uppercase letters that do not have a lowercase version in the string only_upper = {c for c in upper_set if c.lower() not in lower_set} return len(only_upper) - - -def is_upper_case(letter: str) -> str: - return letter.upper()