Method Utility.GetUserAgent fixed when no user-agent is available

Response.End() fixed when issuing an exception.

Author: lorenzobruni

rls/API.Library.dll

@@ -128,6 +128,11 @@ public void ProcessRequest(HttpContext context)
                     }
                 }
             }
+            catch (ThreadAbortException e)
+            {
+                // Thread aborted, do nothing
+                // The finally block will take care of everything safely
+            }
             catch (Exception e)
             {
                 Log.Instance.Fatal(e);
@@ -196,7 +201,15 @@ private void ParseError(ref HttpContext context, string id, JSONRPC_Error error)
             Log.Instance.Info("IP: " + Utility.GetIP() + ", Error Code: " + error.code.ToString() + ", Error Message: " + error.message.ToString() + ", Error Data: " + (error.data == null ? "" : error.data.ToString()));
             object output = new JSONRPC_ResponseError { jsonrpc = JSONRPC_Version, error = error, id = id };
             context.Response.Write(Utility.JsonSerialize_IgnoreLoopingReference(output));
-            context.Response.End();
+
+            try
+            {
+                context.Response.End();
+            }
+            catch (ThreadAbortException e)
+            {
+                // Thread intentially aborted, do nothing
+            }
         }
 
         /// <summary>

rls/API.Library.pdb

@@ -134,7 +134,15 @@ private void ParseError(ref HttpContext context, HttpStatusCode statusCode, stri
             context.Response.StatusCode = (int)statusCode;
             if (!string.IsNullOrEmpty(statusDescription))
                 context.Response.StatusDescription = statusDescription;
-            context.Response.End();
+
+            try
+            {
+                context.Response.End();
+            }
+            catch (ThreadAbortException e)
+            {
+                // Thread intentially aborted, do nothing
+            }
         }
 
         /// <summary>

src/API.Library/Entities/API.JSONRPC.cs

@@ -133,7 +133,7 @@ public static string GetIP()
         /// </summary>
         public static string GetUserAgent()
         {
-            return HttpContext.Current == null ? "" : HttpContext.Current.Request.UserAgent.ToString();
+            return HttpContext.Current.Request.UserAgent == null ? "" : HttpContext.Current.Request.UserAgent;
         }
 
         /// <summary>

src/API.Library/Entities/API.RESTful.cs

@@ -31,8 +31,8 @@
 // You can specify all the values or you can default the Build and Revision Numbers 
 // by using the '*' as shown below:
 // [assembly: AssemblyVersion("1.0.*")]
-[assembly: AssemblyVersion("4.3.0")]
-[assembly: AssemblyFileVersion("4.3.0")]
+[assembly: AssemblyVersion("4.3.1")]
+[assembly: AssemblyFileVersion("4.3.1")]
 
 // Configure log4net using the Web.config file by default
 [assembly: log4net.Config.XmlConfigurator(Watch = true)]

src/API.Library/Entities/Utility.cs

@@ -72,9 +72,9 @@
     <CodeAnalysisRuleSet>MinimumRecommendedRules.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
   <ItemGroup>
-    <Reference Include="API.Library, Version=4.3.0, Culture=neutral, processorArchitecture=MSIL">
+    <Reference Include="API.Library, Version=4.3.1, Culture=neutral, processorArchitecture=MSIL">
       <SpecificVersion>False</SpecificVersion>
-      <HintPath>..\packages\API.Library.4.3.0\API.Library.dll</HintPath>
+      <HintPath>..\packages\API.Library.4.3.1\API.Library.dll</HintPath>
     </Reference>
     <Reference Include="Enyim.Caching, Version=2.16.0.0, Culture=neutral, PublicKeyToken=cec98615db04012e, processorArchitecture=MSIL">
       <HintPath>..\packages\EnyimMemcached.2.16.0\lib\net35\Enyim.Caching.dll</HintPath>

src/API.Library/Properties/AssemblyInfo.cs

@@ -30,5 +30,5 @@
 //
 // You can specify all the values or you can default the Revision and Build Numbers 
 // by using the '*' as shown below:
-[assembly: AssemblyVersion("4.3.0")]
-[assembly: AssemblyFileVersion("4.3.0")]
+[assembly: AssemblyVersion("4.3.1")]
+[assembly: AssemblyFileVersion("4.3.1")]